| mardy | chriadam: hi! Have you seen this? https://git.merproject.org/mer-core/qtcontacts-sqlite/issues/4 | 06:30 |
|---|---|---|
| chriadam | checking now | 06:32 |
| chriadam | it will need to regenerate the display label (even if it currently has data in it) if that display label was previous generated via synthesis. | 06:38 |
| chriadam | of course, if it was provided directly e.g. via sync of FN, then we need to prevent synthetic regeneration somehow. currently that is done via the QContactName__CustomLabelField, but could alternatively be done via an isSynthesized flag in QContactDisplayLabel perhaps | 06:39 |
| mardy | chriadam: I see, makes sense | 06:39 |
| mardy | chriadam: I also files a merge proposal in that project, which should not be too invasive (and could land to master) | 06:40 |
| mardy | chriadam: another topic: it's very likely that both Jolla and Ubports have their own specific quirks on how to use the QContact's fields; would it make sense if we defined a couple of methods like these: | 06:41 |
| mardy | void prepareForStoring(QContact *contact, ContactsEngine *engine); | 06:42 |
| mardy | void fixupAfterLoading(QContact *contact, ContactsEngine *engine); | 06:43 |
| mardy | that will be implemented in a separate file, like contactfixup_stup.cpp (empty implementation), contactfixup_mer (your fixups), contactfixup_ubports (our implementation), and we select between these files at build time | 06:44 |
| mardy | I just made up the names, I bet we can find better ones, but I think you got the point | 06:44 |
| chriadam | is this specifically for sync? | 06:45 |
| chriadam | or can you give an example of such a quirk? | 06:45 |
| mardy | chriadam: for example, Ubports currently stores the contact's initials (what you call LabelGroup, I guess) in the contact's tag | 06:45 |
| chriadam | ok. so the _ubports version would remove the LabelGroup field and place that data into a new Tag detail? or am I misunderstanding? | 06:47 |
| mardy | chriadam: I wouldn't remove the grouplabel field, we just wouldn't be using it | 07:36 |
| mardy | chriadam: OTOH, I plan to add the grouplabel field to QContactDetailLabel in QtPim itself; does it makes sense to you? | 07:37 |
| chriadam | yes | 07:37 |
| chriadam | I have a patch to do so in my backlog somewhere | 07:37 |
| mardy | chriadam: push push :-) | 07:37 |
| chriadam | along with the collection metadata ones | 07:37 |
| chriadam | hopefully I will early next week | 07:38 |
| sledges | PSA: Sailfish OS community collaboration still @ #mer-meeting in 20mins | 07:39 |
| mardy | chriadam: I've updated https://git.merproject.org/mer-core/buteo-sync-plugin-carddav/merge_requests/21 (removed that contentious commit :-) ) | 08:09 |
| chriadam | ;-) thanks | 08:09 |
| ktrace1 | hi | 08:34 |
| ktrace1 | SDK Updater now need wayland. Seriously? | 08:35 |
| ktrace1 | may i fix it? | 08:36 |
| ktrace1 | How i can fix it? or need bugreport? | 08:36 |
| *** ktrace1 is now known as ktrace | 08:37 | |
| Mirv | I'd guess it supports wayland, which means linking to wayland library, which means wayland needs to be installed even if not used.. | 13:04 |
| ktrace | Mirv: it's very sad. i think sailfish os has not too much developers to say goodbye to developers without wayland on PC | 13:29 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!