| Mister_Magister | mal: pingggggggg uhhh why does invoker prevent dbus service starting? | 18:40 |
|---|---|---|
| Mister_Magister | mal: fix for voicecall https://forum.sailfishos.org/t/access-to-contacts-is-not-possible-without-privileged-group/15344 | 18:58 |
| Mister_Magister | not this one | 18:58 |
| Mister_Magister | https://github.com/sailfishos/voicecall/pull/10 | 18:58 |
| Mister_Magister | here | 18:58 |
| mal | on which device? | 18:59 |
| Mister_Magister | mal: it's voiceall issue | 19:11 |
| Mister_Magister | not device issue | 19:11 |
| Mister_Magister | voicecall/invoker/sfos issue | 19:11 |
| Mister_Magister | mal: issue was also not present on 4.3 | 19:15 |
| Mister_Magister | so it's regression | 19:15 |
| mal | what does it really cause? | 19:16 |
| Mister_Magister | mal: it causes dbus service to not start | 19:18 |
| mal | so why doesn't that cause issues on official devices? | 19:19 |
| Tomin | I very much doubt that's the case. From my Xperia 10 II with 4.5.0: https://pastebin.com/XBHpqvW3 | 19:24 |
| mal | Mister_Magister: you are sure it's not adaptation issue like that some sandboxing or something is causing issue, can't remember if invoker does sandboxing | 19:28 |
| Mister_Magister | mal: it does | 19:28 |
| Mister_Magister | it causes issue on all devices | 19:28 |
| mal | on all or all your devices? | 19:29 |
| Mister_Magister | on all of devices | 19:29 |
| Mister_Magister | not all of my devices | 19:29 |
| Mister_Magister | all of devices | 19:29 |
| mal | some examples | 19:29 |
| mal | which have been reported of the official devices | 19:29 |
| Mister_Magister | Xperia 10 II | 19:29 |
| mal | where is such report and logs | 19:29 |
| Mister_Magister | i'll provide you that | 19:30 |
| mal | I still haven't heard what that actually breaks | 19:30 |
| Mister_Magister | give me day | 19:30 |
| Mister_Magister | mal: breaks starting dbus service | 19:30 |
| mal | like functionality | 19:30 |
| Mister_Magister | oh wait | 19:30 |
| Mister_Magister | xperia 10 III too | 19:30 |
| mal | you keep saying dbus but how do you see that in normal use | 19:30 |
| Mister_Magister | i use it to talk to yottagram | 19:30 |
| Mister_Magister | https://openrepos.net/comment/41761#comment-41761 | 19:30 |
| mal | like calls are not working at all, something else+ | 19:30 |
| Mister_Magister | heres guy reportiing it on 10 III | 19:30 |
| Mister_Magister | i know it's not wokring on 10 II | 19:31 |
| Mister_Magister | not working on all of my ports | 19:31 |
| mal | how do you explain that paste from Tomin | 19:31 |
| Mister_Magister | not working on pixel 4 | 19:31 |
| Mister_Magister | mal: sure i'll explain | 19:32 |
| Mister_Magister | mal: https://paste.opensuse.org/pastes/0ba296978629 | 19:34 |
| Mister_Magister | how do you explain this paste | 19:34 |
| mal | so it's not really voicecall-manager being the issue but something in sandboxing preventing third-party apps from accessing it | 19:37 |
| Tomin | voicecall-manager is not sandboxed AFAICT | 19:37 |
| Tomin | are you sure that the issue is not that your plugin is not loaded when invoker is used for launch? | 19:37 |
| Mister_Magister | Tomin: could be | 19:37 |
| Mister_Magister | still invoker issue | 19:37 |
| mal | strace time? | 19:37 |
| Mister_Magister | would you look at that | 19:38 |
| Mister_Magister | Tomin madlad is right on the money https://paste.opensuse.org/pastes/025ff76d584e | 19:38 |
| mal | question is why does that happen | 19:39 |
| Mister_Magister | that's for jolla to figure xd | 19:40 |
| Tomin | invoker makes stracing more complicated because it won't be the process itself but the process is created from booster service. in this case booster-qt5 | 19:40 |
| mal | strace -f might be more useful to see all threads etc | 19:40 |
| Mister_Magister | mal: just tried, same thing | 19:40 |
| Tomin | I think you need to attach strace to the correct booster process and then launch it via invoker | 19:40 |
| mal | Mister_Magister: so did you sheck what you see in strace in both cases in place where is tries to load plugins | 19:41 |
| Tomin | but I don't think we have any instructions on how to do that. and I don't know if it is really that simple | 19:41 |
| Tomin | invoker really just connects to a socket and tells another process to do fork-exec | 19:42 |
| Tomin | so it naturally won't be loading those plugins | 19:42 |
| Mister_Magister | Tomin: https://paste.opensuse.org/pastes/2c78a1e6e432 | 19:43 |
| Mister_Magister | i did what you asked | 19:43 |
| Mister_Magister | it doesn't even take yottagram plugin into consideration | 19:44 |
| Mister_Magister | acts like it's not there | 19:44 |
| Mister_Magister | it's not permissions issue either | 19:45 |
| Mister_Magister | oh wait i might be wrong | 19:45 |
| Mister_Magister | line 1620 | 19:46 |
| Mister_Magister | or 1132 | 19:46 |
| Mister_Magister | would be useful if voicecall-manager outputted anything but here we are | 19:47 |
| Mister_Magister | ye it's loading it | 19:49 |
| Mister_Magister | but dbus service is not starting | 19:49 |
| Mister_Magister | so we did circle and are back at the beginning | 19:49 |
| mal | when stracing use something like -s 2048 so it won't cut out things | 19:52 |
| Mister_Magister | ofcourse its my fault | 19:52 |
| Tomin | yeah, looks like that. It's a strange issue. I can't say right now why would invoker make such a difference, but I think the PR is not the solution. It's something else, I just don't know yet what it should be. -> off to bed for now | 19:52 |
| Mister_Magister | Failed to load plugin: Cannot load library /usr/lib64/voicecall/plugins/libyottagram-voicecall-plugin.so: (/usr/lib64/voicecall/plugins/libyottagram-voicecall-plugin.so: undefined symbol: _ZTI24AbstractVoiceCallHandler)", iov_len=314 | 19:53 |
| mal | that is bad | 19:53 |
| Mister_Magister | then why its not the case without invoker | 19:53 |
| mal | what provides that symbol? | 19:54 |
| Mister_Magister | and what invoker adds anyway, nothing | 19:54 |
| Mister_Magister | i have no clue lol | 19:54 |
| mal | try to find | 19:54 |
| mal | like comparing what libs invoked and non-invoked loads and see if you can find something | 19:54 |
| Mister_Magister | mal: https://github.com/sailfishos/voicecall/blob/master/lib/src/abstractvoicecallhandler.h | 19:55 |
| mal | maybe your plugin is missing some linking? | 19:55 |
| Mister_Magister | like the libvoicecall that jolla removed? | 19:55 |
| Mister_Magister | because and let me quote "it's not used" | 19:55 |
| Mister_Magister | while voicecall literally links against it? | 19:55 |
| Mister_Magister | :) | 19:55 |
| Mister_Magister | https://github.com/sailfishos/voicecall/commit/dd9305a56fbdc103c5d513f5a07257d4a5f3b9a1 | 19:56 |
| Mister_Magister | "This provides nothing to develop with, it's pointless." | 19:56 |
| Mister_Magister | also again, it's not the case without invoker | 19:56 |
| Mister_Magister | and despite removing the .so, plugins link against it still https://github.com/sailfishos/voicecall/blob/master/plugins/plugin.pri#L11 | 19:57 |
| * Mister_Magister is slowly going insnae | 19:57 | |
| mal | have you tried hacking it so that during your build it has the so symlink and links to it? | 19:59 |
| mal | and see if that helps | 19:59 |
| Mister_Magister | how will that help if .so is not there | 19:59 |
| Mister_Magister | also issue is not present without voicecall | 19:59 |
| Mister_Magister | also | 19:59 |
| Mister_Magister | hacking is not the way | 19:59 |
| mal | that .so is only for linking during build, it's not on device | 19:59 |
| Mister_Magister | it's jolla's fault one way or another | 20:00 |
| mal | how about you try that and it it helps then make a PR to request adding the devel package back explaining the issue in detail | 20:00 |
| Mister_Magister | mal: but how will linking against some symlink to nowhere help? | 20:01 |
| mal | argh, don't you understand how linking works during build | 20:01 |
| mal | let me check something | 20:02 |
| Mister_Magister | feel free | 20:02 |
| mal | you can check in build target and see that those .so files are always just symlinks | 20:02 |
| Mister_Magister | mal: the only libvoicecall.so i see is in the /usr/lib64/qt5/qml/org/nemomobile/voicecall/libvoicecall.so | 20:02 |
| Mister_Magister | what? | 20:03 |
| mal | just example from target libturbojpeg.so -> libturbojpeg.so.0 | 20:03 |
| Mister_Magister | ye but they link to some final file | 20:03 |
| Mister_Magister | mal: i'm not sure what are you trying to fix | 20:04 |
| Mister_Magister | building? | 20:04 |
| mal | can't you just do what I said, add the .so symlink which will point to libvoicecall.so.1 to your target, then make your package link against voicecall and then build it and try on device | 20:05 |
| mal | if that helps with invoker then you have your answer | 20:05 |
| Mister_Magister | what libvoicecall.so.1? | 20:05 |
| mal | like /usr/lib64/libvoicecall.so.1 or lib if 32-bit | 20:06 |
| mal | you can see in the commit you linked | 20:06 |
| Mister_Magister | mal: there's no such file | 20:07 |
| mal | so you don't have voicecall installed+ | 20:07 |
| mal | ? | 20:07 |
| Mister_Magister | there's no libvoicecall.so .1 or anything like that | 20:07 |
| Mister_Magister | no you can clearly see it was removed | 20:08 |
| mal | only .so was removed, the others are still there if you have the voicecall-qt5 package installed, which is probably not the case by default in target | 20:08 |
| attah | The regular package provides libvoicecall.so.1, libvoicecall.so.1.0 and libvoicecall.so.1.0.0 | 20:08 |
| Mister_Magister | wait | 20:09 |
| Mister_Magister | you're right | 20:09 |
| Mister_Magister | my bad | 20:09 |
| mal | so after you install that you add the symlink I asked and then try the build | 20:09 |
| Mister_Magister | aight i follow you now | 20:09 |
| Mister_Magister | problem is getting to the target | 20:10 |
| mal | sb2 | 20:10 |
| Mister_Magister | because jolla did some magic in the sd | 20:10 |
| Mister_Magister | sb2 won't work | 20:10 |
| mal | "sb2 -t some_target -R -m sdk-install some_command" if it has issues remove that "-m sdk-install" | 20:11 |
| mal | I use sb2 all the time | 20:11 |
| Mister_Magister | lol that's not the "jolla way" | 20:11 |
| Mister_Magister | ../SailfishOS/bin/sfdk tools exec SailfishOS-4.5.0.18-aarch64 ls /usr/lib64/libvoicecall.so.1 says no such file | 20:11 |
| mal | I never learned the new commands so I just do everything the old way | 20:11 |
| Mister_Magister | xd | 20:11 |
| Mister_Magister | hmm | 20:12 |
| mal | I have a big text file with all kinds of commands sorted by topic, like git command, sb2 stuff etc | 20:12 |
| Mister_Magister | i jsut added linking against voicecall and it just compiled | 20:12 |
| Mister_Magister | weird | 20:12 |
| mal | did you remember to add the linking to your package build | 20:13 |
| mal | like -lvoicecall | 20:13 |
| attah | mal: that's .bash_history for me, and C-p:history-search-backward in .inputrc | 20:13 |
| Mister_Magister | i jsut said i jsut added it | 20:13 |
| Mister_Magister | i include plugin.pri from voicecal | 20:14 |
| mal | attah: yeah, that works also but easier to have them all in one place | 20:14 |
| Mister_Magister | lemme try clean build | 20:14 |
| mal | when some commands are rarely used | 20:14 |
| attah | well... i guess i just set some madness-sized history limit | 20:15 |
| Mister_Magister | what's history limit? | 20:15 |
| Mister_Magister | xddd | 20:15 |
| Mister_Magister | i don't even use bash, fish is way better at suggesting commands | 20:16 |
| Mister_Magister | it even does it based on dir you're in | 20:16 |
| Mister_Magister | when i'm in sfos workspace and do ../ it automatically suggest the sfdk command | 20:16 |
| attah | that seems confusing... but ok | 20:17 |
| attah | SFOS should come with fish as a default just because the name though | 20:17 |
| Mister_Magister | man i had such good day then i decided to figure out why voicecall is broken | 20:18 |
| Mister_Magister | attah: lol but then sdk breaks | 20:18 |
| attah | even now after years of posixifying? | 20:18 |
| Mister_Magister | attah: :) | 20:20 |
| Mister_Magister | it's jolla, do you expect stuff to work? lol | 20:20 |
| attah | generally... yes? | 20:20 |
| attah | "Sailfish OS is the worst OS - except for all the others" | 20:21 |
| Mister_Magister | sweet summer child | 20:21 |
| Mister_Magister | jolla has strange policy to actively seek and prevent users from making apps and from the apps to work | 20:22 |
| Mister_Magister | not to mention qt is at 6.5 and wer are 5.6 it's almost same thing :) | 20:22 |
| attah | Interesting challenge sometimes | 20:25 |
| attah | Well... qt licensing isn't exactly friendly... and gpl3 with phones sold with locked bootloaders might not exactly mix | 20:26 |
| attah | I have been contemplating buying some EFF lawyer time to weigh in on that... but so far i have had better things to do | 20:28 |
| Mister_Magister | mal: ye sfos targets are a magic, i can't add symlink | 20:31 |
| Mister_Magister | i created it in .default but that didn't work | 20:32 |
| Mister_Magister | and i can't access the target the build is using | 20:32 |
| Mister_Magister | there are two targets .default and without .default | 20:33 |
| Mister_Magister | maybe voicecall is not installed after all | 20:35 |
| mal | why wouldn't you be able to add it to target | 20:35 |
| Mister_Magister | https://www.youtube.com/watch?v=P22x0V1OWeI | 20:36 |
| Mister_Magister | added voicecall-qt5 to buildrequires, maybe i'm just dumb and talking out off my ass | 20:37 |
| mal | Mister_Magister: just tested and did it the manual way i.e. "sb2 -t some_target -R" and then in the terminal went to /usr/lib64 and ran ln -s | 20:37 |
| mal | that "sb2 -t some_target -R" opens a terminal in the target | 20:38 |
| Mister_Magister | mal: ye i didn't have voicecall installed my bad | 20:38 |
| Mister_Magister | mal: kay that worked | 20:51 |
| Mister_Magister | long story short | 20:52 |
| Mister_Magister | it wasn't so useless after all | 20:52 |
| mal | so a PR to revert the devel package removal and explain that when invoker is used the linking to voicecall is needed for it to find that one symbol | 20:57 |
| Mister_Magister | mal: | 20:57 |
| Mister_Magister | https://github.com/sailfishos/voicecall/pull/11 | 20:57 |
| Mister_Magister | alredy done | 20:57 |
| mal | maybe mention the missing symbol in the PR | 20:57 |
| Mister_Magister | done | 20:58 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!