| *** spiiroin_ is now known as spiiroin | 06:36 | |
| dcaliste | Good morning pvuorela. I wish you a happy new year and to your family too. | 08:11 |
|---|---|---|
| pvuorela | dcaliste: good morning, happy new year and thank you :) | 08:16 |
| dcaliste | I'm looking at rebasing mkcal#40 at the moment. I don't know if you had the time to give a look. The idea is to ensure at sqliteformat.cpp level that the DB is consistent in terms of parents / exceptions. | 08:23 |
| dcaliste | This looks nice in my opinion, but raise a potential issue that is visible with the alarms : | 08:23 |
| dcaliste | when you delete a parent, the exceptions get automatically deleted also, but they are not reported in the setUpdate() routine. Only the parent is reported, since only the parent where in the deletion list. | 08:24 |
| pvuorela | didn't look too much yet as the previous PR needed to get in first. | 08:25 |
| dcaliste | For the alarms, the consequences can be mitigated by modifying the onUpdated() case. But could it be an issue for the rest of the code ? | 08:26 |
| pvuorela | hard to immediately say. | 08:26 |
| dcaliste | Indeed, and it nrequires to solve conflicts. | 08:26 |
| pvuorela | yea | 08:26 |
| pvuorela | but noted, will take a closer look once rebased. | 08:27 |
| dcaliste | Thanks, that's something that need to be in the balance when analysing the changes... | 08:27 |
| dcaliste | I'm also going to quickly test https://github.com/sailfishos/nemo-qml-plugin-calendar/pull/40 today and maybe update the tst_CalendarEvent::testRecurrenceException() test case to add an exception deletion pattern. | 08:32 |
| pvuorela | thanks, that looked good on the surface. was pondering if it should be included in 4.5.0. | 08:33 |
| dcaliste | I was thinking about the same possibility. I don't remember if the behaviour change was already present in 4.4… If so it would not be a regression not to have it in 4.5, but at the same time it would "fix" a problem of 4.4… | 08:35 |
| dcaliste | It looks still early in the testing phase of 4.5 from an outside point of view, so why not include it still. | 08:36 |
| dcaliste | The PR should be ready today anyway (if testing doesn't reveal something strange). | 08:37 |
| *** amccarthy is now known as Guest174 | 23:39 | |
| *** amccarthy_ is now known as amccarthy | 23:39 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!