| dcaliste | Good morning pvuorela, sorry for the delay. | 07:26 |
|---|---|---|
| pvuorela | dcaliste: morning! | 07:31 |
| pvuorela | np | 07:31 |
| dcaliste | Thank you for the feedback yesterday. It's taking a good direction, in my opinion. | 07:32 |
| pvuorela | indeed, getting quite nice. | 07:33 |
| dcaliste | About the performance issues, and the backgroundItem getting always highlighted, I got it some time on X10ii also. | 07:33 |
| dcaliste | I'm afraid it's a general issue with Qt (?) that is not always sending the mouse release event (I guess). | 07:33 |
| pvuorela | yes, felt like a qt bug. unfortunately. | 07:34 |
| dcaliste | It was visible on heavy load with the keyboard for instance. | 07:34 |
| dcaliste | A bit tricky to investigate though… | 07:34 |
| dcaliste | But unfortunate that it can be trickered more or less easily with the week view… | 07:35 |
| dcaliste | What do you think is still required for this MR ? Code review maybe, when you will have time to ? | 07:39 |
| pvuorela | code review at least. hoping it the coming days i could do that. | 07:41 |
| pvuorela | for one thing, testing that i've some times got the view vertically in some bad position. | 07:42 |
| dcaliste | Great, thanks, but what do you mean ? Events not at the right position in time line on portrait ? | 07:44 |
| pvuorela | the page itself, pulley menu and all | 07:45 |
| pvuorela | testing now version i had from yesterday, flicking weeks got me occasionally some big highlight rectangle in the middle of the screen. looked like pulley menu stuff. | 07:48 |
| dcaliste | Yeh, coming from the pulley menu when the _inactivePosition is not consistent with contentY. | 07:52 |
| dcaliste | I cannot get it on X10ii, even when flicking as fast as I can. I'll try to get an idea how it can be the case from the code. | 07:53 |
| pvuorela | yea, jolla c here. | 07:57 |
| dcaliste | Or reboot my JollaC and test on it ! | 08:00 |
| dcaliste | I'll try to do it tomorrow. | 08:00 |
| pvuorela | that's a good way to test performance issues :) | 08:01 |
| dcaliste | Indeed ! | 08:01 |
| dcaliste | What do you think about the mkcal PR#34 ? It's a cherry-picking from #30, without the API break, but with the read-only revamp stuff. | 08:02 |
| pvuorela | dcaliste: superficially seemed fine and could be easier path to move forward. was prioritizing the week view so didn't yet look more closely. | 08:04 |
| dcaliste | Ok, sure thanks. By the way, I'll be off the coming two weeks. If it's ok for you we can schedule next meeting on Tuesday November 8th. | 08:05 |
| pvuorela | sure. | 08:06 |
| dcaliste | Ah, still about PR#34, do you know if createDefaultNotebook() is used outside mKCal ? In the idea of reducing the exposed functions in mKCal, I don't see the point of this function since it's called from the DB opener and ensure that a default calendar exist. External using of mKCal should not need this routine, should it ? | 08:08 |
| pvuorela | dcaliste: buteo-sync-plugins has a couple references at least. | 08:10 |
| dcaliste | Ah, thanks, alright, I forgot looking into this one. Thanks. I'll looking into it to see if it makes sense to call it there. | 08:12 |
| pvuorela | dcaliste: didn't find other references grepping my git repos. | 08:16 |
| dcaliste | And there is only one unique call in buteo_sync_plugins, in notes, in case the storage didn't return any default notebook, it is creating one with this function. | 08:18 |
| dcaliste | One can wonder if it can be replace by a default Notebook constructor and then a call to setDefaultNotebook(), as I do in PR#34 and remove the function. But it's very minor anyway. | 08:19 |
| *** amccarthy is now known as Guest3368 | 10:53 | |
| *** amccarthy_ is now known as amccarthy | 10:53 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!