| dcaliste | Good morning pvuorela, how are you ? | 07:02 |
|---|---|---|
| pvuorela | dcaliste: heya | 07:02 |
| dcaliste | Thank you for the first code review on the week implementation. I've been busy recently and only just addressed your remarks before the meeting. | 07:03 |
| dcaliste | I'm looking into why the model instanciate 5 objects on start... | 07:04 |
| dcaliste | Did you have time to further test the one-flickable version of the week view ? Is it comfortable to use ? | 07:07 |
| pvuorela | no further testing, but think it was quite fine when i tried it. | 07:09 |
| dcaliste | Alright, I may merge it with the weekview branch then, may I not ? | 07:11 |
| pvuorela | guess so. didn't remember to go through the code side with thought but it's a separate commit and not that big | 07:12 |
| dcaliste | I'll also try a flat integer model for the WeekPanel and see about the instanciation caching if it's better than a rotating indices. | 07:12 |
| pvuorela | alright. myself hoping if that would get it simpler. there's also cacheItemCount in PathView, but not sure can it be related to the current version if there's only three items in the model. | 07:14 |
| dcaliste | If the instanciation is not too agressive, this could be a clean way to avoid to glance at the two-previous weeks on quick flick. | 07:15 |
| dcaliste | I'm testing the integer model at the moment. Qt is instanciating only one in advance. Which is nice. But creation of the WeekLayout instance and destruction of the previous is a bit slow. Even on a Xperia 10ii, I can see a slight slowing of the animation during flick. | 07:36 |
| dcaliste | I can push a commit on top at the moment, and merge it or not later if we prefer the code simplicity of an integer model. | 07:36 |
| dcaliste | What do you think, pvuorela ? | 07:37 |
| pvuorela | more than the earlier? the current it stuttering for me with jolla c between the flick. | 07:37 |
| pvuorela | commit on top sounds fine way to check it. | 07:38 |
| dcaliste | I didn't try on a JollaC, but it seems to me that it's stuttering more with the integer because of the instanciation, while on the rotating version, it's only refreshing an existing instance. | 07:38 |
| dcaliste | I need to fix the function to set the model week index from a given date and I will push the commit on top. | 07:38 |
| dcaliste | Ok, I've finished updated the various functions linking the days between the views (so selecting a day in week view highlights the correct day in Month view...) for the flat integer model. | 08:09 |
| dcaliste | I've pushed a WIP commit on top in the contrib-weekview branch. pvuorela, you can test when you have time and tell me what do you prefer. | 08:10 |
| pvuorela | dcaliste: alright. thanks! | 08:13 |
| dcaliste | Oh, I forgot to mention pvuorela : the new algo to maximize the space for labels in week view is broken for some cases like a short event, a long overlapping event starting a bit later than the first event start, and new small events starting later than the end of the first event. | 08:18 |
| dcaliste | I need to address this with a more robust algo, or move to using the hour layouter. | 08:19 |
| *** Mikaela is now known as Guest1531 | 08:20 | |
| piggz | Keto: any around for fixing up community obs? | 08:52 |
| Keto | piggz: sorry, a bit busy with other stuff | 09:42 |
| Keto | piggz: there was some dod issue again, right? | 09:42 |
| piggz | Keto: yeah | 09:43 |
| piggz | also, the dns, but thats less a pain | 09:43 |
| piggz | :) | 09:43 |
| Keto | piggz: kicked the DoD | 11:17 |
| Keto | piggz: lbt said that disabling/enabling build should help if the DoD is stuck. though in this case I think the problem was that 4.4.0.68 aarch64 DoD was slightly misconfigured | 11:21 |
| piggz | Keto: i presume he is on hols? | 11:26 |
| Keto | just busy | 11:30 |
| piggz | poetaster: might interest you, i think volla22 will ship sailfish support | 21:14 |
| x2s | Interesting | 21:38 |
| x2s | with android app support? | 21:38 |
| piggz | no | 21:40 |
| x2s | :( | 21:43 |
| *** Mister_Magister_ is now known as Mister_Magister | 22:37 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!