| Solrac[m] | Pardon me, I wanted to ask; does AlienDalvik or WayDroid support Bluetooth? | 02:18 |
|---|---|---|
| Nico | mostly no, afaik | 05:10 |
| poetaster | attah, you have nothing better to do than re-implement https://github.com/poetaster/fahrplan/blob/master/src/parser/parser_ninetwo.cpp properly, do you? | 17:52 |
| poetaster | (ducks, runs) | 17:52 |
| attah | poetaster: hmmm | 17:58 |
| attah | what is most improper about it now? | 17:59 |
| poetaster | ah, the programmer that iniated wasn't paying attention to scope. I pushed it into shape, but parser_resrobot.cppparser_resrobot.cpp parser_resobot.cpp does it properly. | 18:00 |
| poetaster | compare https://github.com/poetaster/fahrplan/blob/master/src/parser/parser_resrobot.cpp void ParserResRobot::parseSearchJourney(QNetworkReply *networkReply) | 18:02 |
| poetaster | with https://github.com/poetaster/fahrplan/blob/master/src/parser/parser_ninetwo.cpp | 18:03 |
| poetaster | You don't need to re-write it. I'll do it. Just tell me my scope complaint is correct | 18:03 |
| attah | BRBeer | 18:04 |
| poetaster | Stiftung Edinger hell. A bravarian. It's ok. Yours? | 18:04 |
| poetaster | s/bravarian/bavarian/ | 18:05 |
| attah | Generic lager :/ | 18:05 |
| poetaster | I think that was a freudian slip. I'm a sort of an odd example of a bavarian. Bolivian, Canadian Bavarian. | 18:05 |
| attah | hehe | 18:05 |
| poetaster | it's all your fault that I'm reading waypipe documentation! | 18:06 |
| attah | Then you pay way too much attention to my forum trolling | 18:06 |
| poetaster | Oh, your tone was stern. I can't even FIND my N900, let alone remember what was running on it ;) | 18:07 |
| attah | I only joined in with the N9... probably paid for it with my first actual salary | 18:08 |
| attah | Okay, i need a hint on the scope thing | 18:10 |
| attah | wait | 18:11 |
| attah | pointer of local?! | 18:11 |
| attah | "how did this ever work?" | 18:11 |
| attah | Right... it's never deleted | 18:11 |
| attah | jaay! | 18:11 |
| poetaster | Oh, it's the magic of c++ ... I just looked at it and thought, ok, I'll kick it till it works. | 18:12 |
| poetaster | The JourneyResultItem vs. JourneyResultList scope issue is what I have in mind. But, you have to compare the resrobot | 18:13 |
| poetaster | It's a mundane thing, don't bother. I'm just being lazy :) | 18:13 |
| poetaster | and fahrplan is fully of memory gotchas! yeah! | 18:13 |
| attah | And i realize i had them switched.. so it is in fact resrobot that is leaky | 18:14 |
| poetaster | release() being an aid, but also a kind of crutch ? | 18:15 |
| attah | Seems like a race condition even... is it actually guaranteed to happen in the right order? | 18:16 |
| poetaster | You mean in resrobot where they call parseJourneySegments ? I think I lost you. | 18:17 |
| poetaster | Both methods poll through the json results in 'the' order. | 18:18 |
| attah | That makes two of us :) I mean how it does emit journeyResult(journeyList), with journeyList being a pointer top something new'ed that presumably never gets freed | 18:19 |
| poetaster | It beats me :) The emit shouldn't do more than signal if I remember correctly. | 18:21 |
| attah | Indeed, but you could theoretically have the receiever do the freeing, which is really iffy | 18:22 |
| poetaster | yeah, my take from reading a couple of open prs is that this is a pervasive issue in fahrplan :) | 18:22 |
| attah | Couldn't the lists just be copied in the signals instead... can't be *that* expensive? | 18:26 |
| poetaster | good question, but too much work, I think. I need to look at the abstractions a bit more. | 18:28 |
| poetaster | Just thought about throwing phones into the water off Djurgården during a Kräftskiva. Which expresses how I feel about most of this code :) | 18:35 |
| poetaster | I think I may be wanted in Sweden for eco-terrorism (where mosty nokia phones, though) | 18:36 |
| poetaster | s/were/where/ | 18:36 |
| attah | Code has been rewritten for less... so commendable that you are even touching it | 18:37 |
| poetaster | ok, off I go. | 18:37 |
| attah | happy hunting | 18:37 |
| poetaster | I may through stuff at a tv :) | 18:37 |
| poetaster | ( I hate to see old code go to waste ) | 18:37 |
| attah | Wait... the gazillion memory leak PRs are from 2015? | 18:50 |
| attah | or rather gazillion commits in a PR | 18:50 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!