| dcaliste | Good morning, pvuorela. How are you ? | 08:00 |
|---|---|---|
| pvuorela | dcaliste: hi, i'm good. hope you had a nice vacation. | 08:02 |
| dcaliste | It was great, thanks. Thanks for your comments on https://github.com/sailfishos/buteo-sync-plugin-caldav/pull/10 | 08:03 |
| dcaliste | I've capitalised the globals, and rework the incidenceHrefUri() routine. | 08:04 |
| dcaliste | As commented there, the latter required to rework some of the code path logic in the delta calculation. | 08:04 |
| pvuorela | good, i'll need to check that again. the nemo-calendar side seemed good | 08:04 |
| dcaliste | Hopefully, I've done it right, but I need to test it abit further. | 08:04 |
| dcaliste | I'll address your comments in jolla-calendar#312 later today or tomorrow, I think. I agree that overwrite should be clearer than reset. | 08:07 |
| dcaliste | I spoke to you last time that I wanted to replace the structure duplication from nemo-qml-plugin-calendar by using directly KCalendarCore::Incidence as a storage structure. | 08:08 |
| dcaliste | Doing so, I notice some possible changes that could be done disregarding storage structure that could simplify the code. | 08:09 |
| dcaliste | The first PR is this one : https://github.com/sailfishos/nemo-qml-plugin-calendar/pull/25 | 08:09 |
| dcaliste | It is factorising and providing a base interface for structures that share Event characteristics. | 08:10 |
| dcaliste | What do you think of the intent ? | 08:10 |
| pvuorela | that's so new i only managed to superficially check it. but at least no objections so far :) | 08:11 |
| dcaliste | Sure, I'm not asking for full review already ! | 08:14 |
| dcaliste | I'm preparing another change in nemo-qml-plugin-calendar about the replaceOccurrence() from EventModification(). It is doing some async calls at the moment, requiring some code to get the recurringId when done and propagate it to the query in the UI. | 08:16 |
| dcaliste | After analysing it, I think it can be simplified. The blocking part is the save part, but not the dissociateSingleOccurrence part. | 08:16 |
| dcaliste | So the dissociation could be done first and in sync, which would give the recurringId immediately. And the save() can be done by the normal save() routine with minimal changes. | 08:17 |
| dcaliste | This is also closer to the spirit of how it was designed in KCalendarCore and would simplify the transition to KCalendarCore strutures. | 08:18 |
| pvuorela | alright | 08:19 |
| dcaliste | I think I'll make the PR later today or tomorrow. I need to check various things further. | 08:19 |
| dcaliste | It is breaking the API though :/ and will require a minor change in the UI part (simplification in fact because there is no async fetch of recurringId anymore). | 08:20 |
| pvuorela | sure, but no api stability promises here. | 08:21 |
| dcaliste | Do you know if Martin had time to make progress on calendar UI adjustments for weekview ? | 08:26 |
| dcaliste | No pressure intented, I understand there are may other things he has to work on ! | 08:27 |
| pvuorela | at some point he got back to it for a while but then had to again switch to different things. | 08:27 |
| Mister_Magister | rinigus: ping | 08:28 |
| pvuorela | and at this moment i know he's still busy with stuff :/ | 08:28 |
| dcaliste | Well, that's good already that he gave some thoughts on the matter. It's the kind of thing that can work well in the background of the mind and work better then when you come back to it. | 08:30 |
| dcaliste | I think that's it for today. Thank you pvuorela for the discussion and your reviews and comments on PRs. | 08:36 |
| pvuorela | dcaliste: cheers :) | 08:37 |
| *** v3r3mitz is now known as veremitz | 15:51 | |
| Mister_Magister | rinigus: man i need ya | 16:10 |
| rinigus | Mister_Magister: evening | 16:14 |
| Mister_Magister | rinigus: i was driving with puremaps and i have an issue. While puremaps gets the gps signal and shows my position, it keeps displaying the position as unknown and the navigation is not following my position | 16:15 |
| rinigus | Mister_Magister: what's the error for position estimate? in meters? | 16:15 |
| rinigus | sounds like it doesn't lock fully | 16:15 |
| Mister_Magister | rinigus: i mean it updates the position perfectly fine, idk what error is i'm not sure how to check it even | 16:16 |
| Mister_Magister | like, if i update position manually it calculates it from my position | 16:17 |
| Mister_Magister | but then it doesn't update it | 16:17 |
| rinigus | Mister_Magister: when you don't navigate, it will show the error (uncertainty) on the top right. | 16:17 |
| rinigus | when UI elements overlay the map | 16:18 |
| Mister_Magister | i will try | 16:18 |
| rinigus | what do you mean by "if i update position manually". what kind of GPS is that where you enter position manually? | 16:18 |
| Mister_Magister | rinigus: em when i reroute manually i mean | 16:21 |
| rinigus | please check if it is locked. you could also check with gpsinfo app - it will show error as well | 16:24 |
| rinigus | Mister_Magister: ^ | 16:24 |
| Mister_Magister | i mean if it wasn't locked it wouldn't update the position i imagine | 16:24 |
| Mister_Magister | but will do | 16:25 |
| rinigus | Mister_Magister: It is hard to judge whether it was updating with good precision (default is for under 15m, can be changed in settings) or it is something else. please check | 16:32 |
| Mister_Magister | rinigus: will do | 17:09 |
| Mister_Magister | rinigus: i'm happy to annouince that there is no precision | 18:35 |
| rinigus | Mister_Magister: can you be specific and clear. which program was used to determined precision, what was a readout in that program. if you mean that there is no GPS lock, then state so. | 18:39 |
| Mister_Magister | no like i said couple times already i have gps lock | 18:39 |
| Mister_Magister | there's no precision | 18:39 |
| Mister_Magister | its not being reported | 18:39 |
| Mister_Magister | neither in gps info, neither in puremaps | 18:39 |
| rinigus | Mister_Magister: thanks, getting clearer now. part of getting GPS lock is getting estimation of precision. how many satellites does GPSInfo report as "locked"? | 18:41 |
| Mister_Magister | there is lock, position is being updated, both in gpsinfo and in puremaps, puremaps follows the position but doesn't update it in route and precision in both apps is not being reported at all | 18:41 |
| Mister_Magister | 4 | 18:41 |
| Mister_Magister | if i didn't have lock the position wouldn't be updated | 18:41 |
| Mister_Magister | and the gps icon turns from flashing to solid | 18:41 |
| Mister_Magister | rinigus: pretty sure the gps has the precision its just not being reported back | 18:42 |
| rinigus | Mister_Magister: this 4 is in "use" and then are some more are in "view", right? using gpsinfo terms over here | 18:43 |
| Mister_Magister | yes | 18:43 |
| Mister_Magister | 20 in view 4 in use | 18:43 |
| rinigus | and "horizontal accuracy" is "-"? | 18:43 |
| Mister_Magister | yep | 18:44 |
| rinigus | what about "last update", does that get updated constantly? | 18:44 |
| Mister_Magister | yep | 18:44 |
| Mister_Magister | like i said it has lock, position is being updated | 18:44 |
| Mister_Magister | hecc puremaps follows the position | 18:44 |
| rinigus | then you have to contact your porter. you know, it maybe Mister_Magister :) | 18:44 |
| rinigus | which device is it? | 18:45 |
| Mister_Magister | motorola moto g2 | 18:45 |
| Mister_Magister | it's quite old and old base | 18:45 |
| rinigus | your port, isn't it? | 18:45 |
| Mister_Magister | rinigus: https://www.youtube.com/watch?v=1LVt49l6aP8 | 18:45 |
| rinigus | exactly :) | 18:46 |
| Mister_Magister | :D | 18:46 |
| Mister_Magister | rinigus: couldn't you just… not use the accuracy | 18:46 |
| rinigus | haven't had such issue and don't remember hearing about it. can you fix the port? | 18:46 |
| Mister_Magister | i don't think port is broken | 18:47 |
| Mister_Magister | gps is perfectly fine, always has been | 18:47 |
| rinigus | accuracy is needed - otherwise I cannot judge how far you are from the route. GPS is not fine without precision info | 18:47 |
| rinigus | if you wish, you can hack pure maps on your device and overwrite accuracy info | 18:48 |
| Mister_Magister | was fine till now huh | 18:48 |
| Mister_Magister | ill have a look | 18:48 |
| Mister_Magister | but if it requires me to update base, i'm not doing it | 18:48 |
| rinigus | no, I don't think that you need to update the base. I had it working also on older devices - pretty sure on onyx it was fine. mako - don't remember | 18:49 |
| Mister_Magister | old device != old base | 18:50 |
| rinigus | what's g2 base? | 18:51 |
| Mister_Magister | 12.1 | 18:53 |
| rinigus | Mister_Magister: same as onyx | 18:54 |
| Mister_Magister | hmmmst | 18:54 |
| rinigus | Mister_Magister: not porting info, so giving it here. as I had to wrap Qt positioning source in C++, it is not easy to overwrite from QML GPS precision info in pure maps. you would have to compile your own version if you need it. hopefully you can fix the port | 19:05 |
| * Mister_Magister *grumble grumble* but the port is not broken *grumble grumble* | 19:05 | |
| Mister_Magister | rinigus: imo you should ignore precision if its null | 19:06 |
| rinigus | Mister_Magister: no, I cannot. as soon as you enter a tunnel or data is not as clean as before it would play a role in navigation. pure maps has to figure out whether you have to be rerouted, whether you reached your intermediate destination and it can be chalked off the list. so, no - the precision is a part of the data that is needed | 19:08 |
| * Mister_Magister *grumble grumble* previously it wasn't needed | 19:08 | |
| Mister_Magister | rinigus: https://github.com/mer-hybris/geoclue-providers-hybris/blob/master/hal/hallocationbackend.cpp#L69 | 19:19 |
| Mister_Magister | accuracy is optional | 19:19 |
| Mister_Magister | it's not mandatory nor required | 19:19 |
| Mister_Magister | you should not require accuracy | 19:19 |
| rinigus | Mister_Magister: see my reply above. for navigation it is needed | 19:24 |
| Mister_Magister | not really | 19:24 |
| Mister_Magister | if it was needed it wouldn't be optional | 19:24 |
| Mister_Magister | android navigations somehow work without it | 19:25 |
| piggz | its optional, if you dont want navigation | 19:25 |
| Mister_Magister | no… it's optional with navigation | 19:25 |
| Mister_Magister | android navigation apps work without it just fine | 19:25 |
| Mister_Magister | piggz: rinigus: https://developer.android.com/reference/android/location/Location#getAccuracy() | 19:30 |
| Mister_Magister | It's O P T I O N A L | 19:30 |
| Mister_Magister | ever since beginning of android navigation api | 19:30 |
| rinigus | Mister_Magister: then check in android if you get precision from GPS. I am sure you do | 19:31 |
| Mister_Magister | my android base literally doesn't report it, there is nothing to fix other than puremaps's code | 19:31 |
| rinigus | if user_id == Mister_Magister : set precision to 10m ? | 19:32 |
| Mister_Magister | no? if precision is optional == don't use it? | 19:32 |
| Mister_Magister | it's not "me" problem | 19:32 |
| piggz | Mister_Magister: patch the plugin to fake the accuracy? | 19:33 |
| Mister_Magister | piggz: that's stupid. Don't fix symptoms, fix the source | 19:34 |
| Mister_Magister | the issue is puremaps doing something wrong | 19:34 |
| Mister_Magister | not my device not having something that is optional | 19:34 |
| rinigus | Mister_Magister: it is the first time I hear about device which does not report precision. usually, GPS starts reporting location which is very imprecise, then precision improves, then you get full lock. | 19:34 |
| rinigus | now, if I return your statement - you should fix it in your source. :) | 19:35 |
| rinigus | as for android not reporting it - have you checked that your android base does not report GPS precision? | 19:35 |
| Mister_Magister | man | 19:35 |
| Mister_Magister | it | 19:35 |
| Mister_Magister | is | 19:35 |
| Mister_Magister | optional | 19:36 |
| Mister_Magister | i literally gave you link to android documentation stating that it's optional | 19:38 |
| Mister_Magister | https://github.com/mer-hybris/geoclue-providers-hybris/blob/master/hal/hallocationbackend.cpp#L69 | 19:38 |
| Mister_Magister | here's sfos's code stating its optional | 19:38 |
| Mister_Magister | if you are requiring something that is optional, you are doing mistake | 19:40 |
| rinigus | Mister_Magister: it can be optional on Android or SFOS level, as people can use their device just to tag location. I don't think it is optional for navigation software. As for reasons, those are explained earlier | 19:40 |
| piggz | Mister_Magister: it also says "All locations generated by the LocationManager include horizontal accuracy." | 19:40 |
| Mister_Magister | but it is optional for navigation software | 19:40 |
| Mister_Magister | navigation software works just fine without it | 19:41 |
| Mister_Magister | piggz: true, it does | 19:41 |
| rinigus | Mister_Magister: which navigation software works fine? does it have intermediate destinations, for example? | 19:42 |
| Mister_Magister | installed the same base as the sfos uses | 19:55 |
| Mister_Magister | if i get the accuracy in android then something is broken somewhere on sfos side | 19:55 |
| Mister_Magister | rinigus: i got accuracy on 14.1 base | 19:56 |
| Mister_Magister | so the gps CAN report it | 19:56 |
| rinigus | Mister_Magister: but your base was 12.1, wasn't it? | 19:57 |
| Mister_Magister | yep hence i'ms aying | 19:57 |
| Mister_Magister | [20:55] <Mister_Magister> installed the same base as the sfos uses | 19:58 |
| Mister_Magister | as in im in process of checking | 19:58 |
| rinigus | (I am pretty sure all GPS do report accuracy) good luck with the check! | 19:58 |
| Mister_Magister | good old cyanogenmod | 19:59 |
| Mister_Magister | got the gps app, lets see | 20:01 |
| Mister_Magister | also there's no accuracy before fix | 20:01 |
| rinigus | Mister_Magister: so, got the fix? what about precision? | 20:28 |
| Mister_Magister | rinigus: its still getting the fix | 20:29 |
| Mister_Magister | gimme minute | 20:29 |
| rinigus | 28 already given, one minute wouldn't hurt | 20:29 |
| Mister_Magister | forgot android lacks multitasking and it doesn't get gps when screen is off | 20:30 |
| Mister_Magister | i *might* not be able to get fix | 20:32 |
| Mister_Magister | its been sitting on 4 satellites since like 5 mins | 20:33 |
| Mister_Magister | rinigus: and the answer of the year is yes, it does have accuracy | 20:41 |
| Mister_Magister | it's like 200m | 20:41 |
| Mister_Magister | so ye geoclue is fing me | 20:42 |
| Mister_Magister | ill debug it some other day | 20:46 |
| rinigus | Good luck with it! | 20:51 |
| Mister_Magister | thank | 21:02 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!