| piggz | rinigus: so, currently, just need to drop the as_const changes? | 14:17 |
|---|---|---|
| bionade24 | Nico: Can please explain me how I make application profiling with perf? I already recorded perf data but it doesn't seem to subsitute the adresses with the human readable symbols. | 14:34 |
| rinigus | piggz: yes, I think so. let's keep the rest | 14:58 |
| rinigus | piggz: could you make that as a separate commit with dropping as_const and then maybe it is time to reformat the code? I think it would nicely fit your PR | 14:58 |
| rinigus | piggz: together with reformatting, let's also update TS and I think we could make a release after that. would that be OK? | 15:03 |
| piggz | rinigus: you mean seperate commit as, remove the as_const changes locall and commit, or make them never appear in the PR? | 15:12 |
| rinigus | piggz: I think it is fair enough to add removal commit - so we would have one as suggested by clazy and the next after that correcting it | 15:13 |
| piggz | k | 15:13 |
| piggz | rinigus: pushed | 15:16 |
| rinigus | piggz: reading | 15:16 |
| piggz | rinigus: i also need to remove the include | 15:18 |
| piggz | rinigus: oh, also you thought the qlatin1string changere were not needed? | 15:19 |
| rinigus | piggz: I don't its needed, but I have no major point for or against it. so, let's keep it as it is in your commit now | 15:20 |
| rinigus | started rebuild at OBS | 15:20 |
| rinigus | for gui, to check whether older sfos would work | 15:21 |
| piggz | sure... | 15:21 |
| rinigus | piggz: looks to be building fine for older sfos versions. do you want to reformat whole project? or is it too much... | 15:24 |
| piggz[m] | rinigus: how about reformat after merge | 15:25 |
| piggz[m] | rinigus: pushed another small change to match the clazy suggestion for QLatin1String | 15:25 |
| rinigus | piggz: sure, reformatting can be separate as well | 15:26 |
| rinigus | piggz: weird suggestion, but I guess they had a reason for it | 15:27 |
| rinigus | let's merge | 15:27 |
| piggz[m] | rinigus: cool.... i cant claim to understand all the clazy suggestions either! | 15:28 |
| piggz[m] | there were 3 left over that i couldnt figure out a way to resolve | 15:28 |
| rinigus | piggz: reading the end of https://github.com/KDE/clazy/blob/master/docs/checks/README-empty-qstringliteral.md - we could have used plain QString() there :) . but that we can do in future | 15:31 |
| piggz | yeah, i wondered that too | 15:31 |
| piggz | not that it makes a noticable difference! | 15:31 |
| rinigus | exactly | 15:33 |
| rinigus | piggz: started reading reformat PR | 15:40 |
| piggz[m] | rinigus: cool ... shouldnt be much to look at though, just white space! | 15:41 |
| rinigus | exactly | 15:41 |
| rinigus | piggz: merged. | 15:50 |
| rinigus | piggz: I will regenerate TS and then push it directly to main branch | 15:51 |
| rinigus | piggz: TS strings updated; polish incorporated into builds | 15:59 |
| rinigus | all in main branch already | 15:59 |
| piggz | rinigus: another Pr incoming :) | 15:59 |
| rinigus | piggz: was going to suggest the releasing. well, you let me know when you think it is ready for it | 16:00 |
| rinigus | :) | 16:00 |
| piggz | rinigus: its quite minor... | 16:00 |
| rinigus | piggz: no problem - keep them coming. I am working on adding metadata to chum obs packages | 16:01 |
| piggz | rinigus: i just need to test it doesnt break anything | 16:03 |
| rinigus | piggz: sure, take your time | 16:03 |
| piggz | rinigus: heh, i broke all the github/lab integration :) | 16:29 |
| piggz | just aswell i tested such simple change! | 16:29 |
| rinigus | piggz: :) nice | 16:30 |
| piggz | rinigus: hmm, im getting "Bad Request from the github api | 16:51 |
| piggz | i tested the query in the explorer and it worked fine | 16:52 |
| rinigus | piggz: I would need ot see the change in the code to comment. could be caused by several issues... | 16:53 |
| piggz | rinigus: see https://github.com/sailfishos-chum/sailfishos-chum-gui/tree/raw-strings | 16:54 |
| piggz | just popping out | 16:55 |
| piggz | it shouldnt actually change the strings being passed to the api, just removed the escaping in the string literals | 16:56 |
| rinigus | piggz: there was something with it, later in the submission of strings to api call. I am not sure whether earlier raw string haven't had escape. try to qDebug() print before your change and after | 16:58 |
| rinigus | I think already before it had \" in the string and it was needed somewhere else | 16:59 |
| piggz | yeah, just thought of them | 17:00 |
| piggz | i wonder why .. when i debu print it, ans paste it in explorere its fine | 17:00 |
| rinigus | piggz: it was a bit of a struggle to get it work. let's keep as it is and not touch that (wonderful <- irony) working solution | 17:02 |
| piggz | rinigus: ok .. it just fixes some warnings generated by lupdate | 17:02 |
| rinigus | piggz: right! but its just due to lupdate being not aware of some constructs. I would suggest to ignore it | 17:04 |
| piggz | rinigus: sure ... i also though it was a bit error prone becuase you acutally use the closing escape sequence in the query string eg ") ... but, i guess it works | 17:05 |
| rinigus | piggz: it seems to be able to get over those errors and creates TS that works | 17:06 |
| piggz | rinigus: yeah, only difference in output is the \ around the " in the params ... which was what i was trying to remove ... so, may aswell just release as is | 17:07 |
| rinigus | piggz: question is now what would be a release version? 1.0.0 or 0.3.0? something else? | 17:08 |
| piggz | imok wither either | 17:09 |
| piggz | its just a number :) | 17:10 |
| rinigus | ... thinking .. | 17:11 |
| rinigus | piggz: ok, we can go then for 0.3.0 for now. when translations catch up and we will get issues/bugfixes we can jump to 1.0 when we wish | 17:14 |
| rinigus | piggz: who will do the release? | 17:22 |
| Thaodan | rinigus bionade24: Yes you can reuse that package and update it. There is some use to have it in SailfishOS in general however I'm not sure how much it changes between kernel versions. | 17:28 |
| bionade24 | Thaodan: I'm an absolute perf noob, just used it because callgrind was buggy. Recording and viewing the results went fine (Xperia X), but the function adresses weren't replaced with the debug symbols. Are there any additional packages I need from the repos? | 17:31 |
| Nico | Hm, don't you just need to build with debug symbols? | 17:33 |
| Nico | I mostly use hotspot on my desktop, so I never bothered looking into what I need. I usually just build a RelWithDebug or debugoptimized build | 17:34 |
| bionade24 | Nico: I did use a profile build bc I used callgrind before I'll try with debug build mode. | 17:35 |
| Thaodan | Nico: I don't think that's needed on desktop (arch) it works without debug symbols I think. | 17:35 |
| Nico | What is a profile build? :D | 17:35 |
| Nico | Thaodan: Well, for me some functions were missing without debug symbols | 17:36 |
| Thaodan | Oh yeah true | 17:36 |
| Thaodan | some but most should be there | 17:36 |
| bionade24 | Nico: A option in Qtcreator I haven't comapred the actual compiler flags | 17:36 |
| Thaodan | profile builds are used for pgo builds to get data on how to optimize and then rebuild with that data | 17:36 |
| bionade24 | Thaodan: What's pgo? | 17:37 |
| Nico | Profile guided optimization | 17:38 |
| Nico | Where the optimizer knows,what branches are executed often, because you ran the binary before already and stored some profiling information | 17:38 |
| piggz | rinigus: ill let you .... you know the github release process | 17:56 |
| rinigus | piggz: will do | 18:11 |
| rinigus | piggz: done, v0.3.0 released and tagged. building in chum:testing. want to write announcement to be published when OBS builds are done? | 18:27 |
| piggz[m] | rinigus: sure | 18:34 |
| piggz[m] | rinigus: do we want it in the main Announcing sailfishos:chum thread? | 18:41 |
| rinigus | piggz: either there or a new thread. I don't have huge preference regarding it. bit tilted towards new thread | 18:43 |
| piggz[m] | ok | 18:43 |
| rinigus | piggz: we are ready to go! OBS builds are there (chum regular and testing), all seems to be fine | 18:53 |
| rinigus | piggz: https://chumrpm.netlify.app/ already points to the correct version for GUI | 18:54 |
| piggz[m] | rinigus: https://forum.sailfishos.org/t/announcing-sailfishos-chum-gui-0-3/9839 | 19:08 |
| rinigus | piggz: excellent! now "just" need to add those metadata sections to SPECs | 19:09 |
| piggz[m] | rinigus: just added a litte info about that insecond last para | 19:10 |
| rinigus | piggz: :) | 19:11 |
| rinigus | I am going through my packages. haven't finished yet... | 19:12 |
| piggz | i guess i should do the same | 19:12 |
| rinigus | piggz: especially as Advanced Camera is the number ONE! | 19:20 |
| piggz[m] | rinigus: its hard to get screenshots of advanced camera, it takes control of the vol keys! | 19:23 |
| rinigus | piggz: but you have some at openrepos... | 19:24 |
| piggz[m] | rinigus: yeah, and theyre from a really old version! | 19:25 |
| piggz[m] | maybe there is a command line way of takng a show | 19:25 |
| piggz[m] | shot | 19:25 |
| rinigus | piggz: or compile a version without vol controls? | 19:27 |
| piggz[m] | rinigus: dbus-send --session --print-reply --dest=org.nemomobile.lipstick /org/nemomobile/lipstick/screenshot org.nemomobile.lipstick.saveScreenshot string:"/home/defaultuser/Pictures/Screenshots/Screenshot-$(date +%y-%m-%d | 19:31 |
| piggz[m] | -%H-%M-%S).png" | 19:31 |
| rinigus | piggz: handy | 19:32 |
| piggz[m] | shame its night, not gonna have a nice photo! | 19:34 |
| rinigus | piggz: you can change screenshot later by just swapping it at github repo. just use the same name and no OBS rebuilds are even needed | 19:37 |
| piggz[m] | yeah .. ive taken some now anyway :) | 19:40 |
| piggz[m] | rinigus: your crazy long build times are slowing down my checking my store entry :P | 20:37 |
| rinigus | piggz: I know, I know. suffering as well. haven't yet added valhalla - that one is also a great one | 20:38 |
| rinigus | just hoped I could finish with those bigger ones. but probably valhalla will better wait a bit | 20:39 |
| rinigus | piggz: and sorry for it! | 20:39 |
| bionade24 | rinigus: piggz[m] Why have you decided to not make a general installer like Storeman now has? The architecture selection is rather confusing, even I as dev only remembered only in the last moment, that despite my kernel being aarch64 my system's libraries are amrv7hl | 20:59 |
| bionade24 | rinigus: piggz[m] Maybe options for the officially supported devices could be a solution in the meantime. | 21:01 |
| bionade24 | Since /usr/lib/ld-linux.so --help isn't possible on SFOS I also don't know a place where users could actually detect the necessary arch easily. | 21:14 |
| Thaodan | bionade24: Those devices are just older ports where aarch64 support wasn't there. Nowdays $PORT_ARCH == $ARCH | 21:35 |
| bionade24 | Thaodan: I know, but I thiknk they're many users out there which believe uname -a returns the architecture they need or even just know my XA2 or 10 is 64bit so I guess my packages have to be too. | 21:37 |
| bionade24 | I also find it funny that Go 64-bit binaries work with 32-bit userland but Rust 64bit binaries don't | 21:39 |
| bionade24 | Probably because Rust still links against the libc. | 21:40 |
| Thaodan | As it should IMHO. Rust and Go's staticly linking fetish is backwards. | 21:40 |
| Thaodan | They have no stable abi or d_pointer style classes to emulate that. | 21:41 |
| bionade24 | Thaodan: Yeah, not want to argue about that point. Just find it funny that Rust only does the amount of statically linking they have you bc they still don't have a stable ABI. | 21:42 |
| bionade24 | Nico: I still get "Failed to open /tmp/perf-5036.map, continuing without symbols" and "Failed to open [vectors], continuing without symbols" | 21:43 |
| bionade24 | Nico: In the end all functions are still only named with their adresses, do I need to specify some option to perf report ? | 21:43 |
| Thaodan | Yeah its weird. They have a bug open about that since 2013. I hope it gets better when GCC-Rust moves on. | 21:43 |
| Thaodan | About: perf I couldn't built it, I will try to update and see. | 21:44 |
| Nico | bionade24, how did you install the package? | 21:44 |
| bionade24 | Nico: With pkcon install-local perf-<blablabla>.rpm That still resolved all dependencies and installed correctly. The OBS repo from Thaodan doesn't contain any other packages. | 21:47 |
| bionade24 | Thaodan: Thx | 21:49 |
| Nico | bionade24: No, I meant the code you are debugging | 21:50 |
| Nico | By default rpm strips the debug info | 21:50 |
| bionade24 | Nico: I used the debug build options in Qtcreator. Debug symbols are definately installed. | 21:52 |
| Nico | Hm, could be a permission issue then? No idea :D | 21:52 |
| bionade24 | Nico: The file under /tmp doesn't exist anymore. Maybe somehow related to the fact that I have 1.5GB perf.data | 22:01 |
| Nico | Wow, that's a lot :D | 22:02 |
| bionade24 | Nico: Yeah, the problematic part takes > 1day, but should be possible in under 10min. I want at least some data, but I'll try with a smaller part. | 22:03 |
| Nico | Don't run it for a day. If it should take 10min, run it for 10 min :3 | 22:04 |
| Nico | You can also compress the perf data | 22:04 |
| bionade24 | Nico: I didn't run perf that long | 22:04 |
| Nico | mhm | 22:04 |
| bionade24 | Nico: Ok my phone is weird perf crashed the kernel /o\ | 22:04 |
| Nico | fun | 22:05 |
| bionade24 | Cool everything crashes | 22:46 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!