| piggz | rinigus:looked at the yaml-cpp .spec and it specifies to build the shared version | 13:42 |
|---|---|---|
| rinigus | piggz: no wonder, as it is by Jolla. do you think it is a problem to bundle yaml-cpp lib, as I did in PR? | 13:44 |
| piggz | rinigus: i probably missed the PR ... you might not get much out of me for a few days, my brother and fmily are visiitng | 13:44 |
| rinigus | piggz: no problem - I will look into open issues and let's see how I can proceed. so far, many of them look to be possible to fix in parallel | 13:46 |
| piggz | rinigus: ive started on the manual version setting | 13:46 |
| piggz | rinigus: why all the this-> additions in that PR? | 13:46 |
| rinigus | piggz: otherwise old C++ compiler starts complaining that this method is not accessible. | 13:47 |
| piggz | odd | 13:47 |
| rinigus | piggz: got idea from https://github.com/sailfishos-chum/sailfishos-chum-gui/commit/234438661491f6a46b28a1ff91dbae8109fca593 | 13:47 |
| piggz | rinigus: so, you end up with /usr/share/sailfishos-chum-gui/lib/libyaml-cpp.so .... does the linker find it there? | 13:53 |
| rinigus | piggz: yes. and it is a good question. will have to test, just a minute | 13:54 |
| piggz | ive nothing that old! | 13:55 |
| Thaodan | piggz: if you set -rpath properly it does | 13:56 |
| rinigus | piggz: me neither. | 13:56 |
| piggz | Thaodan: yeah, i was wondering if we would need to add that to the binary | 13:56 |
| Thaodan | however I wouldn't bundle if for newer version | 13:56 |
| rinigus | Thaodan: how can I check rpath, if you remember from the top of your head | 13:57 |
| Thaodan | https://github.com/sailfishos/libsailfishapp/blob/master/data/sailfishapp.prf#L66 | 13:57 |
| Thaodan | That's how its done for libsailfishapp | 13:57 |
| rinigus | Thaodan: re not bundling - you are right, I better add check for SFOS version and do that for older versions only. piggz, will work on that PR a bit and send you new message when ready | 13:58 |
| piggz | ah, so we should be ok, we link sailfishapp | 13:58 |
| rinigus | piggz: but we use cmake :( . not sure it fixes rpath. I'll check in pure maps cmake code to see how it was added | 14:00 |
| rinigus | piggz and Thaodan: for cmake projects, rpath is set via cmake command. as in https://github.com/sailfishos-chum/sailfishos-chum-gui/pull/48/commits/f262df2b41d6e6fb001d4d3e32d206a920d97d7c | 14:15 |
| rinigus | checked before and after with readelf and ldd. result was as expected. | 14:15 |
| rinigus | now would have to add check for SFOS version and bundle for older ones only | 14:16 |
| Thaodan | rinigus: Yeah libsailfishapp has no cmake module so far | 14:53 |
| rinigus | piggz: PR should be ready now. had to include rpmlint config as well as otherwise errors were triggered on rpmlint stage | 15:31 |
| rinigus | piggz: thanks! | 18:56 |
| piggz | rinigus: crap, while working on PR, i hir ctrl-I on chum.cpp :/ | 21:10 |
| rinigus | piggz: what does it do? (depends on editor, I presume) | 22:03 |
| piggz | rinigus: does all the auto-indenting... | 22:05 |
| piggz | i fixed it by doing a diff ignoring white space, then reverting, and applying the diff | 22:06 |
| rinigus | piggz: nasty | 22:06 |
| rinigus | piggz: I remember collectd switched to auto formatting for each commit using clang. that avoided such issues | 22:07 |
| piggz | rinigus: yes, its fair to say that chum.cpp is not intended the way qtcreator expects :D | 22:07 |
| rinigus | but it does require some setup and I don't know how well it would work for qml | 22:08 |
| rinigus | piggz: I wouldn't mind re-formatting it and the rest to be as qtcreator expects. constantly have to adjust and it sometimes slipps | 22:08 |
| piggz | rinigus: yeah, im quite used to just hitting ctrl-a ctrl-i to fix all my formatting ... but only works if file is formatted like that initially | 22:09 |
| rinigus | piggz: we could run that auto-format of yours after PRs are done. just have to make it when we are both aware of it | 22:11 |
| rinigus | as-is, all my work is submitted now | 22:11 |
| piggz | rinigus: my PR is almost ready | 22:12 |
| piggz | rinigus: https://github.com/sailfishos-chum/sailfishos-chum-gui/pull/52 | 22:15 |
| rinigus | piggz: excellent! I will read it tomorrow morning. Already closed pc and going to sleep. We can merge those current PRs and then auto format whole project. | 22:21 |
| rinigus | What do you think? | 22:21 |
| piggz | rinigus: sure ... give it a good read ... seems to work ok for me | 22:21 |
| piggz | sure | 22:22 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!