| rinigus | piggz: and I was waiting for my morning screenshot... Yesterday was reading up on GitHub graphql - looks like a way to go for us. Similar is supported in gitlab. | 05:57 |
|---|---|---|
| piggz[m] | Rinigus: no change to frontend :) | 06:59 |
| mpol | Can someone confirm that busybox / ash sets SHELL=bash as environment? I only have ash installed, rebooted, and it is in my env as nemo user. I would think it is wrong, correct? Since it is not bash, but ash | 11:52 |
| mpol | I have had bash installed previously, so it might just be a leftover somewhere | 11:52 |
| poetaster | rinigus: can you have a peak at https://build.sailfishos.org/package/live_build_log/sailfishos:chum:testing/harbour-beamdimension/3.3.0.16_i486/i586 | 13:45 |
| poetaster | rinigus: seems with my last bump on the spec that something went south. I'm not seeing it. | 13:45 |
| poetaster | well, anyone who can help debug chum. | 13:45 |
| rinigus | poetaster: I hope I can look later tonight. not 100% sure at this moment, sorry | 13:46 |
| poetaster | rinigus: there's time. I'm juggling so probably not seeing something obvious. | 13:47 |
| rinigus | poetaster: I wonder if it is tar_git bug. Try to put `name:` instead of Name: in SPEC description. see source file as downloaded by OBS in your package folder | 14:00 |
| poetaster | got it. | 14:01 |
| mal | rinigus: poetaster: the issue is the Name, not if it's capitalized or not | 14:19 |
| poetaster | mal: danke. | 14:20 |
| poetaster | mal: thanks :) I'm in a german meeting on another channel. | 14:20 |
| mal | poetaster: you can see in the diff of revisions that it uses that Name as the name of the tar.bz2 so Name should be harbour-beamdimension | 14:20 |
| mal | not even sure why you override the name in the chum section | 14:21 |
| poetaster | mal: yes. I think the chum meta needs to exclude name :) | 14:21 |
| poetaster | mal: but thanks for clarifying, I think this was an obvious collision. | 14:22 |
| mal | poetaster: does chum incorrectly use Name for something, instead of using Summary | 14:22 |
| poetaster | mal: it's an experimental stage for including more meta data for the chum gui. | 14:23 |
| poetaster | mal: discussion https://github.com/sailfishos-chum/main/issues/29 | 14:23 |
| mal | poetaster: ok, so maybe you should directly use the existing Summary field or have the new Package as the package name | 14:23 |
| mal | because Name is the rpm name i.e. harbour-* in normal sfos apps | 14:24 |
| poetaster | mal: I'll rework. | 14:24 |
| mal | poetaster: since you have those Package and Name in chum section with same content as Name and Summary elsewhere in spec those Name and Summary should be enough, any other things are fine probably, also wondering if Repo is needed because it probably should match to Url anyway | 14:27 |
| poetaster | mal: you're right on all counts. I'll bring it up with mal and piggz later. thanks. | 14:28 |
| rinigus | mal: the problem with that particular SPEC parsing is that SPEC is grepped incorrectly by tar_git. I suspect it is just using 'Name:' to search for it. | 14:50 |
| rinigus | if I parse using rpmspec, I will get correct response to `rpmspec -q --queryformat='%{NAME} ' test.spec` | 14:51 |
| rinigus | in that spec, I removed %if section for Chum, so it is always loaded | 14:51 |
| rinigus | rpmspec -q --queryformat='%{DESCRIPTION} ' test.spec -- would also lead to correct description with chum section available. | 14:52 |
| mal | rinigus: but Name is used in %setup -q -n %{name}-%{version} which is what caused the build to fail in that example | 14:52 |
| rinigus | mal: Name from chum section should not be read in as it is a part of %description field | 14:53 |
| rinigus | and that's exactly how rpmspec is parsing it | 14:53 |
| mal | is it really? | 14:53 |
| rinigus | note that in the build it is parsed correctly. just tar_git downloads it wrong | 14:53 |
| mal | afaik the order of things in spec is not fixed, you can have other things after description | 14:54 |
| rinigus | well, let me show it via paste. just a sec | 14:54 |
| rinigus | mal: this is SPEC: https://dpaste.org/NKiX . this is parsing https://dpaste.org/MEPM | 14:56 |
| rinigus | mal: and the bug is here: https://github.com/MeeGoIntegration/obs-service-tar-git/blob/master/tar_git#L269 | 14:58 |
| rinigus | ... I think. in general, it is using plain grep instead of something that knows how to parse RPM | 14:59 |
| rinigus | as for Chum needing Name - we would like to have a way to specify human-exposed name to users. instead of something like harbour-beamdimension. Note that Summary field is a sentence - not really a name. | 15:01 |
| rinigus | but to avoid clashing with tar_git, we should probably use some other tag. Package can be used for it, as it is free from tar_git. just confusing. | 15:02 |
| mal | rinigus: probably just don't reuse any of the things already by default in spec | 15:03 |
| rinigus | ExposedName, ForHuman, or some other possible options... | 15:03 |
| mal | PackageName or something | 15:03 |
| rinigus | PackageName is good. | 15:03 |
| rinigus | piggz , poetaster: see discussion above | 15:03 |
| poetaster | rinigus: used Packagename (shit, not camel case). But, that does build. | 16:57 |
| poetaster | piggz, rinigus: submitted what I hope to be usefull packages to chum (useful in testing meta data, that is). | 17:00 |
| Thaodan | what about displayName | 17:15 |
| piggz_ | flypig: acorn is good ... but a little acedemic ... no games :D | 17:24 |
| piggz_ | rinigus: whats the plan tonight for store | 17:29 |
| piggz_ | poetaster: the submissions you made dont follow the revised format I suggested | 17:35 |
| piggz_ | i think we should bottom the spec, document required/optional entries and fix it in stone | 17:36 |
| rinigus | poetaster and piggz_ : sorry, accepted the SPECs at OBS and then read piggz_ message just after that :( | 17:51 |
| rinigus | piggz_: don't know. I wanted to read chum-gui code and figure out the structure of it. maybe we should file issues in its repo and start working on them. | 17:55 |
| rinigus | setting the first standard on SPEC extension would be a good step to do | 17:55 |
| piggz_ | rinigus: let me draft it up and pase something instead of going round the comments | 17:58 |
| piggz_ | s/paste | 17:58 |
| rinigus | piggz_: great! | 17:59 |
| rinigus | I will write down the shortcomings I am aware of as issues in -gui | 17:59 |
| piggz_ | rinigus: live discussion https://pad.riseup.net/p/mC4bMQ6gukQPuLOXWz1O-keep | 18:07 |
| rinigus | piggz_: let's try. do I just remove and replace? or write suggestion in chat | 18:10 |
| piggz_ | rinigus: just edit it | 18:10 |
| piggz_ | as you feel free | 18:11 |
| piggz_ | or write comments | 18:11 |
| piggz_ | doenst need to be in the chat | 18:11 |
| rinigus | piggz_: my comments / changes are in | 18:17 |
| piggz_ | rinigus: adding some info.. | 18:17 |
| piggz_ | rinigus: so, type is as per the appstream spec.... | 18:20 |
| rinigus | piggz_: sounds good! | 18:20 |
| rinigus | now I wonder how we are going to joggle category and package type in GUI | 18:20 |
| rinigus | piggz_: ^ | 18:20 |
| piggz_ | rinigus: category would show the application in that category in the gui/store .... type would be an indication on the pacakge page as to what the type of program is ? | 18:21 |
| rinigus | piggz_: nice! | 18:22 |
| rinigus | piggz_: question, do we want to have libraries also listed in categories? So, "Video" would include only apps or also libs with Video category? In principle, we can add setting to filter and show apps only | 18:24 |
| piggz_ | rinigus: i think we can refine things like that so long as we have the data | 18:31 |
| rinigus | piggz_: agreed! | 18:31 |
| rinigus | now need to write it up and add to chum main repo as a guide. | 18:32 |
| piggz_ | yes | 18:35 |
| piggz_ | on it | 18:35 |
| piggz_ | rinigus: https://github.com/sailfishos-chum/main/blob/meta/Metadata.md | 19:20 |
| rinigus | piggz_: are we using camel case or nocase? PackageName or packagename? | 19:27 |
| piggz_ | rinigus: i was thinking camel to match appstream? | 19:27 |
| rinigus | piggz_: then we have to adjust the example in your (awesome) text | 19:28 |
| piggz_ | true | 19:28 |
| rinigus | piggz_: in the example, you indented YAML metadata. was it on purpose? | 19:29 |
| piggz_ | rinigus: no, its as per copy/paste from spec | 19:31 |
| rinigus | piggz_: maybe we should drop that too - would confuse some | 19:31 |
| piggz_ | rinigus: actually, it must have auto indented .. its not indeted in spec | 19:31 |
| piggz_ | will remove | 19:32 |
| rinigus | probably due to %if | 19:32 |
| piggz_ | rinigus: take another look ... walking dog now :) | 19:33 |
| rinigus | piggz_: I filed few issues and would like to read the code. would need to get a better overview to be able to contribute | 19:34 |
| rinigus | will read your doc first. enjoy the walk | 19:34 |
| piggz_ | rinigus: back ... wondering where to start | 19:59 |
| piggz_ | the parsing code is pretty simple, I gather you want to to most of the work in C++ ? | 20:00 |
| piggz_ | not just shove a blob to QML and do it there? | 20:00 |
| rinigus | piggz_: yes, I think we need to parse in C++ with the properties exposed properly. that would allow to add github/lab as well. | 20:02 |
| rinigus | but I need to read the code first to be up to speed. so far was mainly discussing and reading github/lab apis | 20:02 |
| rinigus | piggz_: btw, does it open cleanly for you in sfos qt creator? for me not - I am getting some cmake errors there. but rpm compiles fine | 20:03 |
| piggz_ | rinigus: yeah, its a pain, ive been editing in kate and building in my t5 sdk! | 20:04 |
| rinigus | piggz_: had the same thought, just wasn't sure how to select between them when package is clicked. hence reading the code :) | 20:08 |
| piggz_ | rinigus: part of the issue is that the list model doesnt parse the description ... thats why there is no icon in the list | 20:09 |
| rinigus | piggz_: I suspect we will need to do that while listing already. as we may want to switch to libzypp, that part has to be figured out as well | 20:11 |
| rinigus | piggz_: actually, we do need to parse all descriptions as we want to show names, categories and such. not necessarily github crawling, but that metadata is already required to list packages | 20:15 |
| rinigus | show names -> use names in the list | 20:16 |
| piggz_ | yes, i know, also for the icon | 20:16 |
| piggz_ | rinigus: still up? | 21:36 |
| piggz_ | rinigus: for when you awaken ... i was able to build chum gui using the sdk app after updating the sdk to latest .... i also had to clear build files written to the source dir from building using build_packages.sh | 22:45 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!