| dcaliste | Good morning flypig ! | 07:05 |
|---|---|---|
| flypig | Good morning! | 07:05 |
| flypig | Thanks for meeting again this week. | 07:05 |
| flypig | So, I was thinking we could include a paragraph or two about your recent contributions. In the past you've written the section, and you'd be welcome to do that again, but if you prefer we can discuss them here and I can write a summary. | 07:08 |
| dcaliste | I planned to write an overview of the Buteo sync framework last time and include recent changes. What is the schedule for it ? | 07:13 |
| flypig | It depends, particularly on how long you'd like it to be. The next newsletter will go out 26.08 (draft deadline this Sunday). But I have a decent amount of material for this already. A couple of paragraphs would go nicely still, but if it's longer like last time (which would also be great) I'd suggest aiming for the 09.09 newsletter. | 07:18 |
| flypig | (just in case it's useful, the general rule is: newsletter every fortnight, draft deadline the Sunday before). | 07:19 |
| dcaliste | What do you think about a quick follow-up from the changes discussed in the previous newsletter for the letter to come and a longer article about Buteo in general a fortnight later ? | 07:21 |
| dcaliste | The follow-up could be about : | 07:22 |
| flypig | I think it's more work for you. But from my perspective that would be really nice. | 07:22 |
| dcaliste | - the recent merge of the Qt6 changes in QMF, | 07:22 |
| dcaliste | - the recent usage of OccurrenceIterator in nemo-qml-plugin-calendar, making a long divergence between upstream and mKCal about EXDATE not necessary anymore, | 07:23 |
| dcaliste | - addition of a new table in the database to fully support attachment from RFC (UI and nemo-qml-plugin-calendar still pending), | 07:26 |
| flypig | Covering those three topics would make a great follow-up. If you're confident about the Buteo text, we could trail that too. | 07:27 |
| dcaliste | Yes, I will have time to prepare a longer text for Buteo if we move the deadline for it to Sunday September 5th. | 07:28 |
| flypig | September 5th will be fine, yes. Okay, should we go through the other three items in a bit more detail to create a summary now then? | 07:31 |
| dcaliste | Yes, let's go : | 07:33 |
| dcaliste | - from newsletter of April 22th, QMF was ported upstream to support Qt6. Changes were made to remove deprecated code. Every changes that is compatible with Qt5.6 have been kept and those requirering more modern version were reverted : see https://github.com/sailfishos/messagingframework/pull/2 | 07:36 |
| dcaliste | So the SailfishOS repo is again in sync with upstream. It allowed to remove some patches that were moved upstream. | 07:38 |
| dcaliste | The main difference that still remains between upstream and the version used in SailfishOS is the patch bringing support to the account framework. | 07:40 |
| dcaliste | This patch is not upstreamable though, because QMF has already a support for account internally and the patch is replacing it with the libaccount one. | 07:40 |
| dcaliste | QMF should be reworked in the sense of introducing a generic account interface and plugin to implement it, providing a default one with its current implementation. | 07:41 |
| dcaliste | Flypig, do you need more information on this topic ? | 07:42 |
| flypig | This is great. I'm just transferring it into a separate document (trying to find something I can use to share it with you). | 07:44 |
| flypig | Okay, here we are. You should be able to make edits too: | 07:46 |
| flypig | https://mensuel.framapad.org/p/63fdjtzo2g-9p7j?lang=en | 07:46 |
| flypig | I'll remove the # headings in the final version, and also (probably it's clear, but just to be sure), lines prefixed with > will be formatted as quotes. | 07:50 |
| dcaliste | Thanks for the framapad. I've added the link for the libaccounts. It's the upstream one. I guess it's fine, you may prefer the mirror one from Sailfish repo, or not. | 07:51 |
| flypig | I think that's great, thank you. | 07:51 |
| flypig | Rather than quoting you, if you prefer, it can be an article written by you instead (i.e. no quotes). | 07:51 |
| flypig | Personally I think that's sufficient for the first topic. Could we do the same for the second (your OccurrenceIterator changes)? | 07:53 |
| dcaliste | Yeh, sorry, I've been away a moment. Indeed, I like the quoting as a reader, it makes the article more lively. | 07:57 |
| dcaliste | Let's move to the second topic : | 07:57 |
| dcaliste | Inherited from the early days of KCalc (see newsletter from July 1st, is it this one actually ?), mKCal was providing a method to get the events of a given period, duplicating the recurring ones accordingly to their rules. | 08:00 |
| dcaliste | This method was obviously taking into account the exceptions, when the occurrence of a recurring series of events is modified, like for instance a recurring meeting that is shifting one hour later at a given date. | 08:01 |
| flypig | Yes, you wrote about MKcal in the 1st July newsletter: https://forum.sailfishos.org/t/sailfish-community-news-1st-july/7153 | 08:02 |
| dcaliste | The implementation of exceptions was done in a smart way not to duplicate code by automatically adding the exceptions as EXDATEs to the recurring rule of the parent event. | 08:03 |
| dcaliste | (RFC: EXDATE is a list of dates for recurring events when there is *no* event, for instance, the regular daily meeting at the coffee machine is obviously cancelled the January 1st). | 08:04 |
| dcaliste | This was a smart move because the expanding code from KCalendarCore then automatically remove the "normal" occurrence thanks to the additional EXDATE and the exception occurrence was present at its peculiar date and time. | 08:06 |
| dcaliste | But this smart idea has a main drawback, it is not RFC compliant, which means that recurring events coming from servers does not follow this rule of additional EXDATE and when we send the event to server we must conform to an RFC compliant definition. | 08:07 |
| dcaliste | In every synchronisation plugin there is code thus to add (and remove) EXDATEs for exceptions on download (upload respectively). | 08:08 |
| dcaliste | Since our recent move to upstream KCalendarCore, we can use a new method that has been added there by KDE developpers to tackle this problem. | 08:09 |
| dcaliste | : the KCalendarCore::OccurrenceIterator class. | 08:09 |
| dcaliste | This class is internally taking into account exceptions without the need to put them in the EXDATE list. | 08:10 |
| dcaliste | The QML plugin for calendar is [now using this upstream method](https://github.com/sailfishos/nemo-qml-plugin-calendar/pull/3). | 08:12 |
| dcaliste | It allowed to remove the code from synchronisation plugins to convert between RFC and mKCal convention, see https://github.com/sailfishos/buteo-sync-plugin-caldav/pull/2 and https://github.com/sailfishos/buteo-sync-plugins-social/pull/1 | 08:14 |
| dcaliste | And the specific code from mKCal has also been removed : https://github.com/sailfishos/mkcal/pull/2 | 08:14 |
| flypig | We can tidy it up fully later, but I think that's looking good so far. Are you happy with the article working along these lines? | 08:23 |
| dcaliste | Yes, I've seen your editorial changes, they looked nice. I've just amended the introduction. The expansion routine is mainly used for display purpose actually. | 08:24 |
| flypig | Thanks for that. I just threw something in, so I'm glad you've corrected it. | 08:25 |
| dcaliste | Do you prefer I actually write the text for the third topic directly ? It would save you some copy-pasting ! | 08:26 |
| dcaliste | You asked also about the release time for these changes : they will be included in the next branching, so from a user point of view in a release > 4.2.0, the next next one. | 08:26 |
| flypig | Do feel free to write it directly if you prefer to do it that way. You're right, it would remove one step of indirection! | 08:28 |
| dcaliste | flypig, in the introduction paragraph, I'm not sure that we should mention "bringing attachment support for invitation" actually this is still a work in progress as far as I can tell, and work that may even not land depending on internal decisions we don't know anything about. | 08:45 |
| dcaliste | My point was just to mention the huge work done by them (and yourself as far as I remember) about the invitation mechanism in general. | 08:45 |
| flypig | Ah, okay, I see. Sorry, I misunderstood. | 08:46 |
| flypig | I'll make changes. Would you mind if we skipped that entirely? It's a nice thing to write, but maybe it complicates things? | 08:46 |
| flypig | I.e. make it more neutral: "Changes continue to be made to the calendar capabilities..." | 08:47 |
| flypig | And I would change the last two paragraphs into quote from you if that's okay? | 08:48 |
| dcaliste | Sure, you're the editor ! If you think it's less confusing without the mention of invitation in general, no problem to remove. | 08:48 |
| dcaliste | I'm ok with quoting the last two paragraphs. | 08:49 |
| flypig | Does something like that look okay? | 08:50 |
| dcaliste | Yes, it's fine like that. | 08:51 |
| flypig | You don't have to accept my edits of course :) | 08:51 |
| flypig | It's surprising how much material there is, but it's a really nice collection of info. | 08:52 |
| flypig | But, because it's quite long, I now feel a bit bad not attributing the entire article to you. Would that be better (we can just remove the quote indents in that case, and I'll add a sentence at the top to introduce it). | 08:53 |
| dcaliste | Your editing looks great. No problem to keep it like that with the quoting. | 08:54 |
| flypig | Okay, then it'll be a really nice addition to the newsletter. Thank you! Is there anything else to add? It'll have to go through more internal editing I'm afraid. | 08:55 |
| dcaliste | I think that's it for the content. No problem for additional edition and proof reading of course. | 08:55 |
| flypig | Yes, I'll carefully go through it again for grammer, spelling etc. | 08:56 |
| flypig | In that case, I'll move it internally now. Feel free to take a copy (I'll clear the public pad later today), and I can send you a "final" copy to check later if you think you'd have time? | 08:57 |
| dcaliste | Ok, send me the material for reading when it's ready. I'll send it back to you quickly lqter. | 08:58 |
| *** karry_ is now known as karry | 08:59 | |
| flypig | Thank you! Thanks so much for this, it's really great. I know it's effort on top of all your other contributions, but I know other people will also appreciate it. | 08:59 |
| dcaliste | Providing information on what is done is also part of the open source idea, or let say open development. That's important. Thank you also for all the editorial work of gathering, layouting and writing for these community letters. | 09:01 |
| flypig | Yes, I agree entirely! | 09:05 |
| dcaliste | I'm going to have a meeting in some minutes with colleagues. I thank you for the joined work today, flypig. I'm waiting for your email for one last proof reading later this week. Have a nice day. | 09:09 |
| flypig | Thank you, that's perfect for me. Have a nice day yourself! | 09:11 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!