| *** zbenjamin_ is now known as zbenjamin | 01:03 | |
| *** frinring_ is now known as frinring | 03:11 | |
| dcaliste | Hello chriadam, how are you ? | 07:06 |
|---|---|---|
| chriadam | hi dcaliste, I'm well thank you. how are you? | 07:07 |
| chriadam | how is your hand? improving, I hope? | 07:08 |
| dcaliste | I'm fine, thank you. My hand is verry slowly improving. I still cannot move much my third finger though. | 07:09 |
| chriadam | hopefully it continues to improve | 07:10 |
| dcaliste | Doctors are optimistic, so why not be myself ;) On another subject, I've encountered a strange behaviour recently having two alarms for my events with exceptions. | 07:11 |
| chriadam | I saw that you created an mkcal PR for something related but didn't have a chance to review it yet | 07:11 |
| dcaliste | It's related to mkcal MR43 | 07:11 |
| dcaliste | But I don't know if it's due to various changes we discussed last week in caldav sync plugin. | 07:12 |
| dcaliste | In particular the fact to remove the copy function in incidencehandler and replace it with kcalcore operator= | 07:12 |
| chriadam | ah, our hand-rolled one might duplicate alarms also in some case where it shouldn't? | 07:13 |
| dcaliste | The issue is from timed where the recurrence id is stored as a string and sometime expressed in my time zone or in UTC. | 07:13 |
| dcaliste | No, no, it's the recurrenceId representation that is failing. | 07:13 |
| chriadam | ah | 07:14 |
| dcaliste | In the handler in mkcal, I still cannot figure out exactly why my exceptions are sometimes represented in my time zone, and sometimes (after sync) are represented in UTC. | 07:14 |
| dcaliste | So, when the mkcal handler try to match an existing alarm to remove it and readd it, the match is failing and it is adding a second with the other representation. | 07:15 |
| chriadam | tz stuff is always tricky :-/ | 07:17 |
| chriadam | I had hoped we had squashed all those possible cases in the past, but I guess not ;-) | 07:17 |
| chriadam | so your PR does what - checks whether it matches in device_tz OR utc_tz representation? | 07:17 |
| dcaliste | The MR, instead of relying on the string representation, is converting back the string to KDateTime, and then, I use operator==, which does the job to compare times whatever the TZ. | 07:18 |
| chriadam | makes sense | 07:19 |
| chriadam | thanks for looking into that. I also wonder why the representation might be different in different circumstances, but perhaps it doesn't matter | 07:20 |
| dcaliste | I still need to test it properly. On paper, (besides implementation mistkes) it looks alright, but I need to use it for some days in real life to be sure. About why the representation is changing, this is my open question at the moment ;) | 07:20 |
| chriadam | not something as simple as "the representation we get from the server changes between syncs" due to server doing weird things? | 07:22 |
| chriadam | most likely it's something tricky on our client side, though, depending on device tz, the phase of the moon, etc :-P | 07:22 |
| dcaliste | I think, it's indeed due to the server changing the representation of recurrenceId, but it was not happening before. So looking at the removal MR of the incidenceHandler::copyIncidence() func, it seems that the recurrenceId was not copied there. | 07:24 |
| dcaliste | So, the original recurrenceId from the creation of the incidence was still used, whatever the server was doing to it. | 07:24 |
| dcaliste | After the MR removing this function, the recurrenceId it indeed changed to the value of the server. | 07:25 |
| dcaliste | That may be the best explanation. | 07:25 |
| chriadam | ah. I wonder if we didn't update it because it matched (kdatetime comparison) even though the representation itself was different | 07:25 |
| chriadam | either way, probably best to always keep in sync with server side | 07:26 |
| dcaliste | Yes and it simplifies the code much, avoid exception for this or that. But it requires to patch mkcal to avoid doubling alarms for exceptions. | 07:26 |
| chriadam | sounds reasonable. thanks. unfortunately I probably won't get a chance to review it this week, but hopefully next week. | 07:27 |
| chriadam | I'm currently deep in qtcontacts-sqlite / qtpim things. finally making the robustness improvements to allow properly separated addressbooks. | 07:28 |
| dcaliste | No problem for the timeline, it will be for version > 3.4.0 anyway, so I have more days to use it and discover minor issues like that. | 07:28 |
| dcaliste | I've seen your branch in git indeed. That's very good, thank you. | 07:29 |
| chriadam | thank you for your patience, and your efforts as always ;-) | 07:29 |
| chriadam | I poked Martin about the jolla-calendar changes, yesterday | 07:29 |
| chriadam | not sure if he has had a chance to look at those yet (I guess not, he just got back from vacation) | 07:29 |
| dcaliste | Thank you. I'm proposing also jolla-calendar!267 to change the focus behaviour when we have finished with the text editing of an event but the keyboard pops up nonetheless. | 07:30 |
| chriadam | great - mentioned that one to martin too | 07:31 |
| dcaliste | Ok thank you very much. Of course he will be very busy returning from vacations, so no hurry. | 07:33 |
| *** vilpan is now known as Guest40248 | 07:33 | |
| *** Guest40248 is now known as vilpan | 07:33 | |
| chriadam | I didn't have anything more to discuss - due to contacts stuff I haven't had a chance to progress any reviews on our side, unfortunately. similarly, I didn't get a chance to look into the TJC issue with syncloop triggered between contactsd and carddav (TJC#229248), but I'm hoping that will be resolved automatically due to the changes I'm making for addressbook separation etc | 07:34 |
| chriadam | aside from those we already covered, did you have anything else to discuss? | 07:35 |
| dcaliste | No problem with time, you're very busy for sure. Just one stupid question, with the new forum based on discourse, what is the best way to mention a topic in a commit ? (like old TJC#xxxxxx) | 07:35 |
| chriadam | I have no idea :-( | 07:36 |
| chriadam | good question... | 07:36 |
| chriadam | one sec | 07:36 |
| chriadam | no response is forthcoming just yet, I will get back to you on that one ;-) | 07:39 |
| dcaliste | Thanks, it's not a big deal, but citing the TJC id was convenient, and there was almost always a TJC entry for something ;) | 07:40 |
| chriadam | indeed | 07:40 |
| chriadam | definitely an important thing to be able to accept community contributions for issues raised on the developer forum, so I'm certain there is a process / tag format, just not sure what it is | 07:40 |
| chriadam | thank you for raising it | 07:41 |
| dcaliste | That being said, thank you for the meeting. I'll continue testing the changes in caldav plugin. | 07:41 |
| chriadam | thanks very much. have a great week! | 07:41 |
| dcaliste | You too. | 07:41 |
| chriadam | gnight! | 07:42 |
| mad_dev | does anyone know how images are served in settings | accounts | service(twitter - google)? | 10:25 |
| flypig | mad_dev, I'm not sure I understand; could you explain a bit more what you're trying to do? | 10:52 |
| mad_dev | flypig, I am working on RTL support. I came across an issue in the account settings page where the mirroring declaration did not affect the icon. | 10:54 |
| mad_dev | https://twitter.com/m4d_d3v/status/1288065021252186112 | 10:54 |
| mad_dev | ^example | 10:54 |
| mad_dev | I checked /usr/share/accounts/ui/twitter.qml | twitter-settings.qml | twitter-update.qml | TwitterSettingsDisplay.qml all in ui/accounts | 10:55 |
| mad_dev | I also checked /usr/lib/qt5/qml/com/jolla/settings/accounts/ nothing stood out | 10:55 |
| flypig | Ah, okay, now I understand. You want the QML page which draws the icon. | 10:55 |
| flypig | Let me have a dig around. | 10:55 |
| mad_dev | flypig, yup. I did find /usr/share/lipstick/eventfeed/twitter-delegate.qml and will test now. However, I don't think it's it | 10:56 |
| flypig | It looks like the actual icon is shown by /usr/lib/qt5/qml/com/jolla/settings/accounts/AccountSummary.qml | 10:59 |
| flypig | Which is included by /usr/lib/qt5/qml/com/jolla/settings/accounts/AccountMainSettingsDisplay.qml | 10:59 |
| flypig | See lines 46-51 of that second file. | 11:00 |
| flypig | Could that be what you're after? | 11:01 |
| mad_dev | hmmm, it could be. I think my mirroring declaration might be the issue. I am using this https://github.com/Logic-gate/unofficial-jolla-language-pack-ar/blob/master/tests/rtl._qml | 11:03 |
| mad_dev | I tested AccountSummary with the declaration, but nothing happened. | 11:03 |
| flypig | The whole issue of RTL is new to me, so I'm not familiar with LayoutMirroring I'm afraid. What would you expect to happen to the icon and text in the summary? | 11:06 |
| mad_dev | to be mirrored to the opposite declared direction | 11:08 |
| mad_dev | I'll test different approaches and report back. Cheers for the help | 11:09 |
| flypig | Reading up on LayoutMirroring (here https://doc.qt.io/qt-5/qml-qtquick-layoutmirroring.html) it looks like the issue is that mirroring applies to rows, but this has been implemented by setting anchors directly. | 11:11 |
| flypig | Although the docs do also say it reverses the anchor settings. | 11:12 |
| mad_dev | Yessssss..it did in fact work, I forgot about whole numbers...0 == 1. https://twitter.com/m4d_d3v/status/1288069942957481984/photo/1 | 11:13 |
| mad_dev | my line numbers were wrong | 11:13 |
| mad_dev | cheers flypig | 11:13 |
| flypig | mad_dev, that's great :) | 11:14 |
| flypig | mad_dev, out of curiosity, what do you mean by whole numbers here? | 11:15 |
| mad_dev | My approach to RTL support is to simple append the declaration at certain line. I use cat -n which starts count from 1. But sed counts from 0 as usual. So every time I see the place where the declaration needs to be, I need to subtract one...so, a simple mistake from my part | 11:18 |
| mad_dev | https://github.com/Logic-gate/unofficial-jolla-language-pack-ar/blob/master/tests/rtls.sh#L41 | 11:18 |
| mad_dev | A rudimentary approach...but it works | 11:19 |
| mad_dev | whole numbers as in 0, 1, 2, 3 | 11:20 |
| mad_dev | ...and yes. This is done manually :) I go through each file, find the most suitable line, then append. | 11:23 |
| flypig | mad_dev, thanks for the explanation; that makes perfect sense then! | 11:36 |
| flypig | It sounds like a lot of work for you, but sometimes the simplest solutions work best, especially when you're figuring things out still. | 11:37 |
| mad_dev | Yup, the other solution is sounds cool but it's not practical. An initialization wrapper which starts apps, if the system locale is set to an RTL language, insert RTL declaration at the beginning of each file. If not, launch normally. | 11:45 |
| mad_dev | Just a thought, never explored it more. | 11:45 |
| zotan | with rpmbuild is there an easy way to stop it rebuilding everytime? My install step is failing, but the build step takes 20 minutes :-( | 16:59 |
| flypig | zotan, apparently you can do `rpmbuild --short-circuit -bi /path/to/specfile` | 17:01 |
| flypig | I've not tried it, but someone said it here: https://serverfault.com/a/217561 | 17:01 |
| zotan | flypig: That seems to work, thanks! | 17:05 |
| flypig | Great :) | 17:05 |
| piggz | flypig: anything to report on network first boot issue? | 21:51 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!