| *** zbenjamin is now known as Guest57301 | 01:48 | |
| *** zbenjamin_ is now known as zbenjamin | 01:48 | |
| *** frinring_ is now known as frinring | 02:13 | |
| dcaliste | Hello chriadam, if you don't mind, give me 5 minutes before our meeting... | 06:59 |
|---|---|---|
| chriadam | hi dcaliste, no problem at all | 06:59 |
| chriadam | no rush | 06:59 |
| dcaliste | Hello chriadam, I'm here. From time to time, will have to leave some minutes to give directions for school at home ! | 07:05 |
| chriadam | no problem :-) | 07:06 |
| chriadam | I hope you had a good week | 07:06 |
| dcaliste | Thank you for nerging last week the percent encoding URL potential issue in CalDAV. | 07:06 |
| dcaliste | I'm using regularly now the new discovery code and it seems to work. | 07:06 |
| chriadam | great, I will review that asap and get it merged. also flypig checked the mkcal+nqpc MRs and I will merge and tag those shortly also | 07:07 |
| chriadam | thanks also for your review comments on Bea's buteo PR | 07:07 |
| dcaliste | Ok, that good, thank you. | 07:07 |
| dcaliste | Sorry, comments are coming not all at once :/ Added yet some others this morning... | 07:08 |
| chriadam | all good :-) | 07:08 |
| dcaliste | About pending MRs, there are some that may have moved out of view, like... | 07:09 |
| dcaliste | https://git.sailfishos.org/mer-core/buteo-syncfw/merge_requests/45 | 07:10 |
| dcaliste | https://git.sailfishos.org/mer-core/kcalcore/merge_requests/15 | 07:10 |
| chriadam | urgh yes, let me check those again | 07:10 |
| dcaliste | They are not of prime importance, no problem. | 07:11 |
| chriadam | let me try to find a bug number which might be associated with the buteo one | 07:13 |
| dcaliste | If MER bugs still exist, I can create one if it helps. | 07:16 |
| chriadam | I created JB#49486 for synchronisation UI | 07:19 |
| chriadam | I guess buteo-syncfw MR#43 and MR45 are related | 07:19 |
| dcaliste | Yes, indeed, thank you. | 07:20 |
| chriadam | at least MR#45 LGTM I will merge that tomorrow | 07:20 |
| dcaliste | Great, thanks again. | 07:20 |
| chriadam | thank you, and for bringing it to my attention again. I had somehow forgotten about those. | 07:21 |
| dcaliste | Another more recent MR that may be of interest : https://git.sailfishos.org/mer-core/mkcal/merge_requests/36 | 07:21 |
| dcaliste | It may be of interest to flypig also. | 07:21 |
| dcaliste | As mentioned in the MR discussion, the triggered errors look like some he faced some time ago. | 07:22 |
| dcaliste | To reproduce : down sync a recurring event with exception occurrences. | 07:22 |
| dcaliste | Then, delete it on server. When down syncing again, it will fail with the reported error messages. | 07:23 |
| dcaliste | This is due to the fact that mkcal is internally storing a list of nodification indexed by uid alone. | 07:23 |
| chriadam | delete the entire series on the server? | 07:24 |
| chriadam | or just the exception occurrence? | 07:24 |
| dcaliste | Most of the place, they check recurrenceid also on the given list of matching uid, except for the insert / delete action. | 07:24 |
| dcaliste | Yes, delete all the event, recurring and exceptions. | 07:24 |
| chriadam | I will find a bug number for that too | 07:26 |
| chriadam | JB#24579 is actually about this issue | 07:28 |
| dcaliste | Oh, great. I'm going to add it. | 07:29 |
| chriadam | the bug is actually for the case where the parent series was deleted but not the exception occurrence, I think, but not sure. old bug, and I might be misunderstanding the case | 07:30 |
| chriadam | either way, related. | 07:30 |
| chriadam | does that caldav MR#64 have a TJC related? | 07:32 |
| dcaliste | Yes, there are 3 commits there, and the one with the TJC is mentioned (I think). | 07:33 |
| dcaliste | Yes, it's TJC#223428 | 07:33 |
| dcaliste | The last commit of the MR. | 07:33 |
| chriadam | ah great | 07:34 |
| chriadam | that just leaves the tz ones without a related bug number currently | 07:35 |
| dcaliste | Which one are they ? These tz MRs I mean ? | 07:36 |
| chriadam | mkcal#17 and nqpc#49 | 07:36 |
| chriadam | maybe pvuorela could suggest which bug might be related to that one. I know there's an "upgrade kcalcore" task, so maybe it is related to that | 07:36 |
| dcaliste | Ah yes, these ones. | 07:37 |
| dcaliste | Yes, why not put the "upgrade kcalcore" one, it's indeed related, even if not that closely. | 07:38 |
| chriadam | there's another task, JB#43311 which might be better, related to all-day recurring events from exchange being displayed on wrong date. I thought I'd fixed that already, but perhaps not.. | 07:40 |
| dcaliste | Ok, I'll add this one later today on both, so you can merge later on. | 07:41 |
| chriadam | thanks very much | 07:41 |
| dcaliste | Yesterday, I begun to work on the last stage for the alarms not to trigger for disabled notebook or account : https://git.sailfishos.org/mer-core/nemo-qml-plugin-calendar/merge_requests/55 | 07:41 |
| dcaliste | It's explained in the MR discussion what has been done by flypig already and what this MR is brining in addition. | 07:41 |
| chriadam | ah, I need to fix the google calendar. it was storing something in the syncProfile() field, should instead use notebook custom properties for that, and store the "proper" thing in the syncProfile() field | 07:43 |
| dcaliste | Ah yes, ok. I've looked on my device and didn't see anything there. But I disbaled sync since a long time and code should have changed since. | 07:44 |
| dcaliste | For Google plugin I mean. | 07:44 |
| chriadam | I also might be mis-remembering, and nothing might be stored there | 07:45 |
| chriadam | will check | 07:45 |
| dcaliste | Ok, thank you. | 07:45 |
| chriadam | regarding the MR, I think flypig knows the most about that one, as he worked on the related things before, so I will ask him to review and test when he gets a chance | 07:45 |
| chriadam | thanks very much for doing that | 07:46 |
| dcaliste | Last very minor MR for today : https://git.sailfishos.org/mer-core/mkcal/merge_requests/37 | 07:46 |
| dcaliste | I think pvuorela did the review of the initial code, so he may be a better reviewer for this one. | 07:47 |
| dcaliste | It's about silencing the flood of warnings of the calendar app about account not being able to send mail. | 07:47 |
| chriadam | yes, shouldn't have been a warning | 07:48 |
| dcaliste | Not very important, but easier then to debug previous MR about notebook listing ! | 07:49 |
| chriadam | ;-) | 07:49 |
| chriadam | I very much appreciate the hard work and effort you have put into helping improve the quality of these components | 07:50 |
| chriadam | I apologise for being slow to review some of these | 07:50 |
| chriadam | thanks again for poking me, hopefully will get most of them merged and tagged this week | 07:50 |
| chriadam | (probably not the notebook visibility one, depends on what flypig has on his plate currently) | 07:50 |
| dcaliste | Sure, of course, no problem. | 07:51 |
| dcaliste | Thank you also for listening and reviewing, it's a long work also. | 07:51 |
| chriadam | anything else to discuss today? | 07:51 |
| chriadam | if not, I hope you have a great week! | 07:52 |
| dcaliste | No, that's all (already a long list !). Thank you and wishing you a good week too. | 07:53 |
| chriadam | thanks! | 07:53 |
| chriadam | gnight | 07:53 |
| kirvesAxe | I wonder if someone will make a port of Sailfish (X) for this..? https://www.indiegogo.com/projects/astro-slide-5g-transformer#/ | 13:03 |
| *** svartoyg is now known as svartoyg_afk | 22:52 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!