| *** zbenjamin is now known as Guest33469 | 02:51 | |
| *** zbenjamin_ is now known as zbenjamin | 02:51 | |
| dcaliste_ | Hello chriadam, how are you ? | 07:57 |
|---|---|---|
| chriadam | hi dcaliste_ I'm well thanks. how are you? recovered from your illness I hope? | 07:58 |
| dcaliste_ | So so. Today meeting may be shorten than usual because I need to stay at home and look over my son doing his school at home... | 08:00 |
| dcaliste_ | About your mkcal MR to add a guard against cancelled status, I'm sorry, I was not clear yesterday : you cannot call setAlarm() from updateNotebook(). | 08:03 |
| dcaliste_ | Indeed, this setAlarm() is using calendar() internally, but when calling updateNotebook(), the calendar may not be up-to-date and may not contain any of the events at hand. | 08:04 |
| chriadam | no problem - it's definitely an interesting time at the moment. I hope you recover swiftly! | 08:04 |
| chriadam | ah | 08:04 |
| chriadam | makes sense. I will undo my change, and add the required check into the setAlarmsForNotebook() method | 08:05 |
| dcaliste_ | That's why I made all these setAlarm() and resetAlarm() protected method, so nobody can call them without knowing about this internal event in calendar handling. | 08:05 |
| chriadam | ah! silly me. thank you for explaining | 08:05 |
| dcaliste_ | As I commented in gitlab, it is better in fact to put it in Private::setAlarm(), because the status is part of the event. | 08:06 |
| dcaliste_ | It's a tricky part, and I'm happy that these functions are not public API anymore, so we can change them as we want. | 08:06 |
| chriadam | sounds good | 08:06 |
| chriadam | I saw that you updated the caldav PR related to current-user-principal. thanks for that - I will check it properly tomorrow | 08:08 |
| chriadam | gitlab isn't loading comments currently for me, unfortunately, but I think mkcal MR#17 is ready also, is that true? | 08:11 |
| dcaliste_ | Yes, I added a test for and noticed that my fix broke your case ! | 08:12 |
| chriadam | there is some associated change in n-q-p-calendar if memory serves, I wonder if we psuhed that one yet, let me chec | 08:12 |
| dcaliste_ | Yes, mkcal!17 goes with a MR in nemo-qml-plugin-calendar. | 08:12 |
| dcaliste_ | Don't remember which one... | 08:12 |
| dcaliste_ | And gitlab is a bit tired at the moment. | 08:13 |
| chriadam | save all day exception as clocktime to be zone free? MR#49? | 08:13 |
| dcaliste_ | Yes, sounds like it. | 08:13 |
| chriadam | flypig: pvuorela: any issues with me merging those two this week? | 08:14 |
| chriadam | nemo-qml-plugin-calendar MR#49 and mkcal MR#17 | 08:14 |
| dcaliste_ | I wanted to point to a TJC cbeta report also, but TJC is not loading neither... | 08:15 |
| dcaliste_ | About CalDAV, failing on an exception defined outside the recurrence. | 08:16 |
| chriadam | that one sounds similar to the issue flypig filed, should be fixed now IIRC | 08:17 |
| dcaliste_ | You fixed it recently with a MR in caldav. I wanted to know if you think it can be pushed in a upgrade-3.3.0 branch or not ? | 08:17 |
| chriadam | oh | 08:17 |
| chriadam | interesting question | 08:17 |
| chriadam | pvuorela: do you know whether 3.3.0 is accepting fixes still? getting quite late in release cycle now unfortunately.. | 08:18 |
| chriadam | well, he might not have started work today yet. I will follow up with him. unfortunately, I think 3.3.0 is probably closed to new fixes | 08:20 |
| chriadam | but let's see | 08:20 |
| dcaliste_ | Yeh, I was afraid of this... | 08:21 |
| dcaliste_ | Then There are two points about on-going work : | 08:21 |
| dcaliste_ | - a MR in caldav (that will need be rebased when the current-user-principal is in) to add more discovery code in initialisation, particularly for read-only notebooks. | 08:22 |
| dcaliste_ | - the work shared with flypig about the proper handling of alarms for disabled account or calendars. | 08:23 |
| chriadam | has that "proper handling of alarms" stuff been merged? I thought it was already? | 08:23 |
| dcaliste_ | For the later, only disbaled accounts are now working. We planned a step 3 for disabled calendars. With changes to be done in nemo-qml-plugin-calendar. | 08:23 |
| chriadam | ah | 08:23 |
| dcaliste_ | I begun to gave a look, and had trouble with reverse association between account service and notebooks. | 08:24 |
| chriadam | thought we stored the accountId in the notebook? | 08:24 |
| chriadam | oh, you mean, notebook uid should be stored in the accoutn settings? | 08:25 |
| dcaliste_ | Because it would require to know from account in nemo-qml-plugin-calendar if the service handling the notebook at hand is disabled. | 08:25 |
| chriadam | ah | 08:25 |
| chriadam | I see | 08:25 |
| chriadam | flypig had added something liek that to contactsd | 08:25 |
| dcaliste_ | I need to do more tests and research about this. | 08:26 |
| dcaliste_ | Thanks for pointing this to me. | 08:26 |
| chriadam | but he only checked caldav+google-calendar, with: checking for service.type === "caldav" || (service.type === "sync" && service.name === "google.Calendar") | 08:26 |
| chriadam | but something more is probably required for activesync unfortunately | 08:26 |
| chriadam | and we should have some generic way :-/ | 08:26 |
| dcaliste_ | Yeh, will continue to discuss this next meeting I think. I need to continue thinking about this. | 08:28 |
| chriadam | sounds good. hopefully flypig can join us next week also | 08:29 |
| chriadam | did you have anything else to discuss this week? | 08:29 |
| dcaliste_ | No, that's it. Thank you. | 08:30 |
| chriadam | thank you very much. I hope you and your family stay safe during these stressful times! | 08:30 |
| chriadam | see you next week! | 08:30 |
| dcaliste_ | Yeh, it will be fine, weather is good and home comfortable ;) | 08:30 |
| dcaliste_ | See you. | 08:31 |
| chriadam | great :-) gnight! | 08:31 |
| *** ecloud is now known as ecloud_wfh | 10:38 | |
| rinigus | now what are the odds to have a topic removed TWICE from the meeting agenda at TJC. let's try again... | 12:25 |
| mal | rinigus: which topic? | 12:26 |
| rinigus | mal: general question regarding qt update | 12:28 |
| mal | why was it removed, by mistake? | 12:28 |
| rinigus | I think others just happened to edit at the same time | 12:28 |
| mal | ah | 12:29 |
| Mister_Magister | hmm google accounts seem to not work anymore, i had problems with deleting emails past months but now i can't even receive them. tried removing and readding account and now it's stuck on updating accoutn after trying to refresh emails | 12:31 |
| *** frinring_ is now known as frinring | 13:55 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!