| abranson | What does that do? | 00:00 |
|---|---|---|
| r0kk3rz | https://together.jolla.com/question/221851/x-nemo-single-instanceno-is-not-respected/ | 00:00 |
| r0kk3rz | a compositor hack and maybe some event plumbing i think | 00:00 |
| r0kk3rz | https://github.com/sailfishos-flatpak/flatpak-runner | 00:02 |
| abranson | Interesting! | 00:06 |
| *** zbenjamin is now known as Guest42543 | 02:20 | |
| *** zbenjamin_ is now known as zbenjamin | 02:20 | |
| *** SpeedEvil is now known as Guest94953 | 02:22 | |
| *** BitEvil is now known as SpeedEvil | 02:53 | |
| rinigus | r0kk3rz: flatpak-runner is also config app. you can set env vars, qt scaling, dpi (default and app-specific). | 06:29 |
| rinigus | as it also now generates gl extension on start for you, it has desktop file to make it simple | 06:30 |
| rinigus | abranson: flatpak does add desktop files in XDG, but its ignored by lipstick | 06:33 |
| rinigus | right now I am using it for our advantage by generating new desktop files under .local/share/applications and changing Exec to `flatpak-runner flatpak-app-name` . its rather crude, but works normally. could probably extract Exec command and just replace bits in it. | 06:35 |
| rinigus | abranson: flatpak-runner contains wayland compositor used by flatpak apps, ensures that it rotates with the device and assists with maliit keyboard required info (rotation and whether app is active) | 06:36 |
| abranson | rinigus: fixed teh XDG_DATA_DIRS in lipstick fairly recently: https://git.sailfishos.org/mer-core/lipstick/merge_requests/122 | 07:01 |
| abranson | might be more robust to somehow integrate that flatpak-runner functionality into the flatpak binary itself? then you could let flatpak look after the desktop files | 07:02 |
| rinigus | abranson: do you know whether that fix is already published in sfos 3.2.1.x? | 07:04 |
| rinigus | we probably still need a wrapper as we have to open new wayland compositor and rotate it. plus send data to maliit plugin inside flatpak | 07:05 |
| rinigus | re fix - as I don't have any extra icons coming on after flatpak app installs | 07:06 |
| abranson | does it need to be a wrapper specifically, or just called during flatpak app init? | 07:06 |
| rinigus | right now its a wrapper. in addition to functions listed above - our compositor does not support minimizing => apps disappear from screen if you switch them or lock the screen | 07:08 |
| abranson | hmm that fix should be in there... | 07:08 |
| rinigus | xdg_data_dirs are set in my environment | 07:09 |
| rinigus | to point to flatpak exports, so should work already. but doesn't :( | 07:10 |
| abranson | set in /var/lib/environment/compositor/ ? | 07:11 |
| rinigus | abranson: don't know where. in terminal, the var is set | 07:18 |
| rinigus | abranson: in compositor, I don't think so | 07:18 |
| rinigus | abranson: do you know why single instance = no support is not working in lipstick? its a bummer right now as we can have only one flatpak app running in a time... | 07:20 |
| abranson | rinigus: no, but I bet no-one's used it for a long time | 07:35 |
| abranson | didn't the harmattan browser use that? | 07:35 |
| abranson | add a conf file to that dir and lipstick should get it | 07:36 |
| rinigus | abranson: there is a patch around - can you folks somehow restore single-instance=no? | 07:37 |
| abranson | will have a look | 07:37 |
| rinigus | abranson: thanks! | 07:38 |
| abranson | oh, it worked for r0kk3rz? might not be so simple | 07:38 |
| rinigus | abranson: I have no idea why it worked for r0kk3rz . I am not 100% sure whether he started them from app grid though | 07:39 |
| rinigus | abranson: do you know whether your lipstick fix also applied for icons search path? from looking into the code it seemed to me that it didn't | 07:40 |
| abranson | no, that's more complicated to fix because it involves the theme paths | 07:41 |
| rinigus | abranson: I better not distract you from single-instance=no fix. those smaller annoyances can come later :) | 07:43 |
| abranson | rinigus: looking at that single-instance thing, i'm not sure if that's what you want. you'd be launching multiple instances of the same flatpak apps. | 08:15 |
| abranson | looking in that Switcher qml that the patch applies to, there's an 'isAndroidApplication' function that takes the first arg of the command as the identifier instead. that might be better for your use case as long as there's no other side effects. | 08:16 |
| abranson | it's a simple check for a 'X-apkd-apkfile' key in the desktop file by the looks of it | 08:16 |
| rinigus | abranson: if it is possible to make it more clever than plain single-instance=no - even better. so, what should I specify in `X-apkd-apkfile`? | 08:28 |
| abranson | rinigus: looks like it's returning: launcherItem.readValue("X-apkd-apkfile") != "" | 08:28 |
| abranson | so i guess whatever you like. might be nicer to put the package name there maybe | 08:29 |
| abranson | hopefully that won't cause any strangeness elsewhere. like trying to launch aliendalvik ;) | 08:29 |
| rinigus | abranson: I will try tonight ... although, don't have aliendalvik - so cannot test it | 08:30 |
| rinigus | abranson: although, its still not clear why different .desktop files (one per app) would lead to launcher to consider them the same app. | 08:34 |
| abranson | check the function windowIndexOf in that Switcher.qml | 08:38 |
| rinigus | abranson: will do, thanks | 08:39 |
| abranson | yw | 08:41 |
| abranson | rinigus: looking a bit further down, you may also need to set window.surface.className in your flatpak apps. they are analogous to android apps, but it's still going to be a bit of a hack. | 08:49 |
| rinigus | abranson: where do I set that (window.surface.className)? | 08:50 |
| rinigus | in .desktop file? | 08:50 |
| abranson | i guess it's a property of the wayland surface, so in your runner? | 08:51 |
| rinigus | abranson: will have to look into how to set that | 08:56 |
| abranson | yeah sorry i'm guessing now :) good luck | 08:57 |
| abranson | var window = Lipstick.compositor.windowForId(switcherModel.windowId(i)) | 08:57 |
| rinigus | thanks! | 08:58 |
| dcaliste | @flypig, do you want some help on https://bitbucket.org/jolla/ui-jolla-settings-accounts/pull-requests/67/accounts-move-foldersyncpolicy-setting/diff ? If you are busy with various things, I can address some of jpetrell comments ? | 09:59 |
| flypig | @dcaliste, thanks for the offer. It's awkward, because while it would be useful, I'm halfway through addressing a bunch of them. I think I'd have to commit my changes first before it would make sense. | 10:00 |
| dcaliste | Sure, I would start from your work anyway. As you prefer. | 10:01 |
| flypig | One thing that I've not looked at yet is this issue of the "initial state". When things are first set up, some account types have all folders with sync flag set, some have none. | 10:01 |
| dcaliste | As commented on git @ SFOS, I've quickly tested the full stack on device, and it seems to work. | 10:01 |
| flypig | Great, I didn't get to your comments yet, but that's good to hear :) | 10:02 |
| dcaliste | Yes, that's right. I didn't look at it neither... I thought first that QMF was setting this to True by default. | 10:02 |
| dcaliste | Otherwise it would create now (before my patches) some issues of folder not synced. | 10:02 |
| flypig | That would make sense, but apparently it's not always the case. Or maybe other things may have changed them for existing accounts. | 10:03 |
| flypig | I'm not sure Google and EAS were respecting the flags though. | 10:03 |
| dcaliste | So, I let you have look to the full stack status when you have the time to and ping me if you need help on something. | 10:04 |
| dcaliste | I don't know about the status for me to access eas repo to look at your patches. Currently I'm not allowed to. | 10:05 |
| flypig | Ah, okay, I'll follow that up. | 10:05 |
| flypig | Sorry about that. | 10:05 |
| dcaliste | No problem, not in a hurry from my side ;) | 10:05 |
| flypig | Well, I'm sorry, as I'm sure you must be keen to see it finalised (as am I) and it's frustrating if you have some time but I'm blocking things. | 10:06 |
| dcaliste | No, no, you're not don't worry. | 10:07 |
| flypig | Nevertheless, I'll try to get my current changes committed as a WIP ASAP :) | 10:07 |
| dcaliste | I plan this thing with synchronizationEnabled flag because I thought at first that it was designed for and not intrusive. But you showed my it was a bit more complex. | 10:07 |
| dcaliste | So it needs more time to polish it, no problem. | 10:07 |
| flypig | Well, your version was fine when it was applied only to IMAP. It's the extension to the other types that seem to have complicated things. But we're getting there! | 10:08 |
| dcaliste | @flypig, for the record, the synchronization flag is set in imapclient.cpp#825 in ::mailboxListed(). For pop, (for what it's worth), it's in popclient.cpp#309. | 10:18 |
| dcaliste | I don't know for imap, if there can be some code paths that are creating a folder different from the one mentioned here though... | 10:19 |
| flypig | dcaliste, that's useful, thank you. Can POP3 have folders? | 10:35 |
| dcaliste | No, but internally in QMF it has one, the Inbox one. | 10:35 |
| dcaliste | And it has flag set also. | 10:36 |
| flypig | Okay :) I've asked again about EAS, but it's not looking straightforward. I'd like to get you access, but it may not be possible. | 10:36 |
| dcaliste | But it's no used anywhere (well, almost, grep is returning one match of usage in pop code). | 10:36 |
| dcaliste | @flypig, no problem, it was for review anyway. | 10:37 |
| flypig | It would really help for you to have the full picture, in my view, but we'll see. | 10:37 |
| dcaliste | not that review are useless ;) | 10:37 |
| dcaliste | On the contrary of course. | 10:37 |
| flypig | :) | 10:38 |
| *** frinring_ is now known as frinring | 10:40 | |
| rinigus | abranson: summarized my experience so far in sfos-devel mailing list. in short, nothing works perfectly. while I can get several instances up, its a mess. didn't try android hack - that would require different cmd line, as I can guess. | 21:30 |
| *** zama_ is now known as zama | 21:45 | |
| abranson | rinigus: i don't think so, it just uses the first arg instead of the binary name | 21:46 |
| rinigus | abranson: cmd.split(' ')[2] is probably 3rd? | 21:47 |
| abranson | And you set that wayland classname field to whatever the flatpak packag name is | 21:47 |
| abranson | Ok, maybe. | 21:48 |
| rinigus | will have to see how to set that classname and to which window... | 21:49 |
| abranson | But we can probably slip in some support for flatpak desktop files | 21:49 |
| rinigus | I am off to sleep, will read logs/replies tomorrow | 21:49 |
| Sailor3354_ | wich apk is working for YouTube on my device ? | 22:19 |
| BenKerry | Hey | 22:31 |
| BenKerry | Whats Up | 22:32 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!