| *** zbenjamin is now known as Guest73504 | 02:33 | |
| *** zbenjamin_ is now known as zbenjamin | 02:33 | |
| *** frinring_ is now known as frinring | 05:22 | |
| dcaliste | Hello chriadam, happy new year ! | 08:18 |
|---|---|---|
| chriadam | hi dcaliste, happy new year to you also! | 08:18 |
| chriadam | I hope you have been well | 08:18 |
| dcaliste | Yes, fine, better actually than usual hectic end of year period. | 08:19 |
| chriadam | excellent! yes, I know what you mean, super busy time of year | 08:20 |
| dcaliste | I'm reading your comment at the moment. | 08:21 |
| chriadam | unfortunately I haven't had an opportunity to follow up on your fixes. I added some brief comments to the two new caldav ones, but haven't yet tested those on device, will do so and merge tomorrow unless flypig has some comments there; but aside from that haven't had a chance to look at the mkcal / kcalcore / nemo-qml-plugin-calendar ones | 08:21 |
| chriadam | I saw that flypig had merged those fixes you provided for the exception occurrence issue you discovered previously - thanks for that! | 08:22 |
| dcaliste | Yes, I thank @flypig for his review, understanding of the issue… | 08:22 |
| flypig | Thanks also from me, you were a great help explaining things dcaliste. | 08:23 |
| Venemo | hey | 08:23 |
| chriadam | hi Venemo | 08:23 |
| dcaliste | About MR!61 for CalDAV plugin, yes, the mNotebookSyncDate is the date at sync start, and if the reception of some incidence occurs one or second after, and the last-modification tag is missing, libical is adding one with the current date. | 08:23 |
| dcaliste | So, later than the notebook sync date. | 08:23 |
| dcaliste | On next sync, the incidence is then reported as locally modified. | 08:24 |
| chriadam | dcaliste: and I guess that happens if the incidence doesn't have a specific timestamp set it in previously when synced (e.g. CREATED / MODIFIED fields)? | 08:24 |
| chriadam | interesting case, and must have been tricky to track down. nice work. | 08:24 |
| dcaliste | If both are missing, in fact, there is no issue. | 08:24 |
| dcaliste | because… | 08:24 |
| dcaliste | created == last-modification (> notebook sync date), and the modifiedIncidences(sinceFoo) routine is returning incidences for last-modification > created and last-modification > sinecFoo. | 08:25 |
| chriadam | ah, so if the timestamps are equal, it doesn't get returned there. hah! but if one or the other exists, then it can "pass" and be returned... interesting | 08:26 |
| dcaliste | But if created is provided and not last-modification, then the incidence will be reported as modified which is failing for read-only calendars like the shared one in NextCloud. | 08:26 |
| chriadam | yup | 08:26 |
| dcaliste | That was the case for the events Benjamin reported and he noticed the missing last-modification. | 08:27 |
| chriadam | interesting that we didn't see this ourselves while testing our nextcloud support. oops. | 08:27 |
| chriadam | great catch | 08:27 |
| *** ro is now known as Guest38652 | 08:28 | |
| chriadam | just a quick roundup of outstanding stuff, still trying to get my brain in gear after some time off over christmas/new year: | 08:28 |
| chriadam | 1) those caldav PRs, 2) the mkcal PR#17 to detect all-day events stored with tz, 3) the nemo-qml-plugin-calendar PR#49 to support that one by saving all-day exception as clocktime. also 4) the kcalcore MR#13 to store with RFC semantics to avoid the addDays(-1) or whatever thing, but that one will require some "orchestration" i.e. I need to update all plugins, and test, and bump versions at the same time | 08:30 |
| chriadam | so I think that (4) might wait a little while longer unfortunately | 08:30 |
| chriadam | for (1) as mentioned, I hopefully will test and merge tomorrow | 08:30 |
| chriadam | for (2) and (3) do you think those are ready? I believe they are/were, was just waiting for comments from pvuorela or flypig on those - I will ask them to take a look at those again just in case fresh eyes spot something | 08:31 |
| dcaliste | Yep, that's it. No problem to postpone 4) for a while. | 08:34 |
| chriadam | excellent. thanks again for all the work you have been doing and continue to do. | 08:34 |
| chriadam | did you have anything else to discuss? e.g. was there any blockers on the webcal subscription side that you'd like me to poke peopel about? | 08:34 |
| chriadam | also, regarding the next meetings: I am available tuesday 21st and tuesday 28th, but then am taking a vacation in february so won't be available during feb for meetings - maybe flypig could chair those meetings instead during that period. | 08:35 |
| dcaliste | About webcal stuff, I've reworked the UI settings to use the account. | 08:37 |
| dcaliste | pvuorela is looking at it. | 08:37 |
| chriadam | great | 08:37 |
| dcaliste | For the meetings, no problem have nice holydays when it comes in February. | 08:38 |
| dcaliste | If I have questions I can still ping pvuorela of flypig. | 08:38 |
| chriadam | yep :-) thank you | 08:38 |
| chriadam | if nothing else to discuss, then have a good week and see you next tuesday! | 08:39 |
| dcaliste | Yes, have a nice week and a good evening. Thank you. | 08:39 |
| *** vilpan is now known as Guest69942 | 08:52 | |
| *** Guest69942 is now known as vilpan | 08:52 | |
| *** vilpan is now known as Guest97922 | 11:40 | |
| *** Guest97922 is now known as vilpan | 11:40 | |
| *** R is now known as Guest84496 | 13:46 | |
| *** vilpan is now known as Guest94094 | 15:42 | |
| enigma9o7 | sailfish is rather bossy sometimes, particularly when I inpug it from my charger. It always tells me to unplug my charger from the wall, telling me it'll save power or something. I don't even know if I believe it about the power savings part, but I'm mainly just tired of it trying to tell me what to do! | 18:05 |
| mal | those usually consume a little bit of energy even when not charging, it's not much but still something | 18:14 |
| kimmoli | that is one small contribution to slow down climate change... | 19:09 |
| tanriol | ...at least unless the charger wear offsets it. | 19:24 |
| *** frinring_ is now known as frinring | 23:17 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!