| *** ahjolinna__ is now known as ahjolinna | 00:36 | |
| *** ecloud is now known as ecloud_wfh | 06:05 | |
| dcaliste | Hello chriadam, how are you ? | 06:57 |
|---|---|---|
| chriadam | hello dcaliste, I am well thanks. How are you? | 06:57 |
| dcaliste | I fine, thank you. | 06:57 |
| dcaliste | 'm | 06:57 |
| dcaliste | Thanks for the GPG stuff landing in 3.1.0 ;) it's great, but a little mistake pass through: https://bitbucket.org/jolla/ui-jolla-email/pull-requests/441 | 06:58 |
| chriadam | ah, I will check that one | 06:58 |
| chriadam | thanks | 06:58 |
| dcaliste | My fault when renoming variable in QML… | 06:58 |
| chriadam | I also saw you were looking into folder sync with imap | 06:58 |
| dcaliste | Indeed. | 06:59 |
| dcaliste | Make it works with QMF SynchronizationEnabled flag is easy, but I'lm fighting with how to enable this in UI. | 06:59 |
| chriadam | ah. jpetrell may be able to help (but I think he's out of office today, not sure) | 06:59 |
| dcaliste | The buteo-qml-plugins-email MR is the first part: enabling it. | 07:00 |
| dcaliste | Then, comes two MRs, one in nemo-qml_plugin-email to expose this SynchronizationEnbaled flag, and one in jolla-setting-accounts for the UI part. | 07:00 |
| dcaliste | I was divided in two options for the UI part: | 07:01 |
| dcaliste | * either put a textswitch in the folder virew in email app itself enabling or not the synchronization, or | 07:01 |
| dcaliste | * put a folder list in account settings with the synchronization schedule. | 07:02 |
| dcaliste | I chose the later and to avoid overcrowding the setting page, I put the folder list behind a combobox, so the folder list is expanded only when the user choose full details. | 07:03 |
| dcaliste | A bit like for the synchronization combobox, proposing usual choices and a custom mode if not. | 07:03 |
| chriadam | sounds like a good solution | 07:03 |
| chriadam | but again, when it comes to UI stuff, I defer to jpetrell ;-) | 07:04 |
| dcaliste | Indeed ;) Let say it's first draft then ;) I'll try to find him later on to discuss with him (and attach screenshots in the MR for quicker references). | 07:05 |
| chriadam | sounds good, thanks | 07:05 |
| chriadam | regarding the mkcal PRs, flypig and I will review those this week | 07:06 |
| dcaliste | Ok nice thank you both. | 07:06 |
| dcaliste | Maybe you've seen also this MR https://git.merproject.org/mer-core/buteo-sync-plugin-caldav/merge_requests/45 for CalDAV ? | 07:07 |
| chriadam | let me check | 07:07 |
| dcaliste | I've still left the WIP tag because I want to test, but I think I won't add modifications any more. | 07:08 |
| chriadam | I hadn't seen that one yet | 07:08 |
| dcaliste | It's about simplifying as much as possible the notebooksyncagent code. | 07:08 |
| dcaliste | Trying to reduce its length to make it easier to maintain or change. | 07:08 |
| chriadam | sounds good - I probably won't get to reviewing that one this week unfortunately | 07:08 |
| dcaliste | It enable TODO handling also, at this level (still needed in reader part). | 07:09 |
| dcaliste | No problem for time frame, it's not in a hurry. | 07:09 |
| flypig | chriadam, dcaliste, at some point during the discussion, can I ask about the mkal!17 MR, please? | 07:12 |
| dcaliste | pvuorela: https://github.com/sailfishos/sailfish-office/pull/129 <- just a UI tweak after document app has been switch not to use drawer anymore. | 07:12 |
| dcaliste | flypig: sure go ahead. | 07:12 |
| chriadam | dcaliste: pvuorela is on vacation at the moment, he's back next week | 07:12 |
| chriadam | flypig: go for it | 07:12 |
| flypig | dcaliste, thanks :) | 07:12 |
| dcaliste | chriadam: ok no problem. | 07:13 |
| flypig | First, sorry for not being more proactive, but I am confused about the state as it stands. | 07:13 |
| flypig | Could you summarise for me dcaliste? | 07:13 |
| flypig | Especially the relationship with MRs 19-22 | 07:14 |
| dcaliste | flypig: in fact !17 will be removed, it is replaced by several smaller MRs, see !19, !20 and !21 I think. | 07:14 |
| dcaliste | So mainly, the core of !17 is becoming !22 | 07:14 |
| flypig | Okay, great, this is what I was confused by. | 07:14 |
| flypig | So 21 and 22 still need review? | 07:15 |
| dcaliste | The idea of it is to refactorize the date and time read and write to help centralize possible corrections on all day detection for instance. | 07:15 |
| dcaliste | Yep, !21 and !22. | 07:15 |
| flypig | I see that 21 isn't very complex | 07:15 |
| dcaliste | In fact !21 is a consequences of !22 (I commented it there I think). | 07:16 |
| dcaliste | Sorry for the reverse numbering (!21 being a consequence of !22), I notice it later after reworking !17 into smaller commits. | 07:16 |
| flypig | Okay, perfect. So is it still useful for me to take a look at these today? Again, I apologise for not having done this sooner. | 07:16 |
| dcaliste | flypig: don't worry, I know everyone is busy ;) | 07:17 |
| flypig | dcaliste, you're very gracious, but I delayed unnecessarily because I was a bit confused. I apologise. | 07:17 |
| dcaliste | With pvuorela having accepted the MR with test cases it's easier to see the influence of !21 and !22. You'll notice that in the current state, one test is failing. It's the detection of all day depending on various iCal format, as you have investigated already. | 07:19 |
| dcaliste | Normally, !22 should solve it. | 07:19 |
| dcaliste | Sorry, myself for not commenting in !17 that it was going to be replaced by smaller ones. | 07:20 |
| flypig | When you say "the current state", you mean it's failing on current master *without* 22 | 07:20 |
| dcaliste | flypig: excat. | 07:20 |
| dcaliste | exact. | 07:20 |
| flypig | dcaliste, great, got it, thanks. Just to be sure : | 07:20 |
| flypig | dcaliste, you did comment, and you were clear, but I more than a couple of MRs and I get confused. | 07:21 |
| flypig | :( | 07:21 |
| flypig | dcaliste, chriadam, the situation is much clearer for me now and I have a direction, so that's all good. Thanks. | 07:23 |
| dcaliste | chriadam: ah and the GMT+- bug should be corrected by !22, you may notice in the readDateTime helper routine, that when the time zone is FLOATING_DATE, the actual value is read from index + 1 instead of index only before the patch. | 07:24 |
| dcaliste | flypig: thanks to you for feedback and valuable testing ! | 07:24 |
| chriadam | flypig: we mainly need to figure out what the appropriate fix for internal bug 43708 is. I suspect that one of dcaliste's PRs will resolve that. but if not, we need to investigate further. | 07:25 |
| merbot | chriadam: Error: Error getting Mer bug #43708: InvalidBugId | 07:25 |
| chriadam | so that's the MR22 I guess | 07:25 |
| chriadam | dcaliste: thanks for splitting that one up too :-) | 07:25 |
| flypig | chriadam, thanks, that's useful to know. I can look at it in the context of 43708 then. | 07:26 |
| dcaliste | chriadam: well technically it's still linked with the refactoring, because it would have been boring to patch every places… | 07:28 |
| chriadam | yes, we should get them all in if possible | 07:28 |
| chriadam | anything which improves the quality of the code is good | 07:29 |
| chriadam | did we cover everything, or did I forget something? I will definitely follow up on the jolla-email fix for the signature stuff. Aside from that, I will also look into the mkcal PRs tomorrow or Thursday, unless flypig beats me to it. the other (caldav + foldersync) things will not be this week unfortunately. | 07:30 |
| dcaliste | chriadam: that's it. Time frame is good ! | 07:32 |
| chriadam | great :-) I'll be online for another 20 mins or so, but then will head home. please ping me if there's something else which comes to mind :-) aside from that, have a great week! | 07:32 |
| dcaliste | Thanks, you too. | 07:33 |
| dcaliste | jpetrell: https://github.com/sailfishos/sailfish-office/pull/129 <- just a UI tweak after document app has been switch not to use drawer anymore because currently, pulling down makes the toolbar appears in PDF viewer… | 07:34 |
| jpetrell | dcaliste: cheers, looks good :) | 09:20 |
| dcaliste | jpetrell: as said, I'm sorry I didn't try your rework earlier, I should have propose feedback earlier. But besides this little thing, the rest is nice to use. | 09:22 |
| jpetrell | dcaliste: good to hear. :) touched code that you had written so there is non-zero change that I accidentally break some edge use cases | 09:24 |
| dcaliste | jpetrell: I've quickly tested the link menu opening, including device rotation in zoomed in documents and everything is still placed well. So no problem besides this small toolbar showing issue, as far as I've seen up to now. | 09:28 |
| dcaliste | jpetrell: another point, not in a hurry at all. When you have time and design team also, may you give a look to https://bitbucket.org/jolla/ui-jolla-settings-accounts/pull-requests/42 ? | 09:30 |
| sledges | We're pushing on with our next release, means another batch of strings are waiting for your help to translate. Since round 1, Czech, German, both Portuguese, Russian, and Turkish need more love :) https://together.jolla.com/question/208113/official-announcement-l10n-strings-for-310-round-2/ | 09:37 |
| *** frinring_ is now known as frinring | 09:46 | |
| pdanek | Hello! | 12:15 |
| pdanek | Is the Aurora OS fork any good? | 12:16 |
| pdanek | I heard news Huawei might use the Aurora OS instead of Android. | 12:16 |
| pdanek | That made me excited. | 12:16 |
| leszek | pdanek: AuroraOS is basically a rebranded SailfishOS without AD and country specific modifications and/or apps | 12:19 |
| pdanek | Nice | 12:20 |
| pdanek | So finally Sailfish has chance to get popularity if Huawei goes for it? | 12:21 |
| pdanek | I am former Maemo / Sailfish user, but had to move to Android long time ago, but this news make me hyped. | 12:21 |
| Umeaboy | Hi! I want to reinstall sailfish-browser, but I can't find how to tell pkcon to do so in --help. | 13:36 |
| Umeaboy | pkcon install --downgrade sailfish-browser doesn't seem to help much. | 13:37 |
| mal | --allow-reinstall | 13:37 |
| Umeaboy | .....either. | 13:37 |
| Umeaboy | So pkcon install --allow-reinstall sailfish-browser | 13:38 |
| Umeaboy | ? | 13:38 |
| mal | or the option before install | 13:39 |
| Umeaboy | Okey. Since I updated to 3.0.0.10 sailfish-browser has begun to act even more weird. | 13:47 |
| mal | isn't 3.0.0 quite old already | 13:48 |
| Umeaboy | 3.0.3.10. Sorry, my bad. | 13:49 |
| Umeaboy | If I clear all the downloads regardless if they worked or not they still show up again and I'm once again notified about Sailfish failing to download them. | 13:52 |
| Umeaboy | That's why I thought that reinstalling the browser might work. | 13:52 |
| Umeaboy | Reinstalling sailfish-browser did not do the trick | 13:53 |
| Umeaboy | What else can I try? | 13:53 |
| zebbiz_pi | Umeaboy: Have you deleted the files? Cleared the browser data? | 13:55 |
| Umeaboy | Yes. | 13:55 |
| Umeaboy | No luck. | 14:02 |
| Umeaboy | Any other solution? | 14:03 |
| zebbiz_pi | Have you tried turning it off and on again? :P | 14:03 |
| Umeaboy | Yes. | 14:03 |
| Umeaboy | I can do it again though. | 14:04 |
| Umeaboy | I'll be back. | 14:04 |
| zebbiz_pi | Pojken från ume är tillbaks! | 14:07 |
| zebbiz_pi | Any change? | 14:08 |
| Umeaboy | Nope. Still the same. | 14:08 |
| zebbiz_pi | Weird | 14:08 |
| Umeaboy | Yeah. | 14:08 |
| Umeaboy | I can reset the system, but I prefer NOT to. | 14:09 |
| mal | so the command still didn't work? try installing zypper in use that to force install | 14:12 |
| mal | *and use | 14:12 |
| Umeaboy | zypper is already installed. | 14:26 |
| Umeaboy | Now what? | 14:27 |
| dcaliste | Umeaboy: `pkcon install sailfish-browser` should reinstall the browser to the current version without any additional argument. Before doing it, you need your repo listing to be up to date, so a `pkcon refresh` is required. | 14:33 |
| dcaliste | Just tested on my device, it is doing the job. | 14:34 |
| dcaliste | But I'm not convinced this will solve your download issue because, I'm afraid this is related to some setting / cache files in the home user. | 14:35 |
| mal | zypper has --force option | 14:35 |
| mal | which is more forceful than pkcon | 14:36 |
| Umeaboy | Nope. Problem still persists even after running pkcon install sailfish-browser && pkcon refresh | 14:44 |
| Umeaboy | I'm beginning to think that it's connected to my user account. | 14:44 |
| mal | try zypper like I said many times | 14:45 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!