| *** ChanServ sets mode: +v T4 | 02:18 | |
| *** zama_ is now known as zama | 08:10 | |
| *** ChanServ sets mode: +v T4 | 08:36 | |
| T4 | <akaWolf> @neochapay https://github.com/nemomobile-ux/glacier-settings/pull/15 | 13:58 |
|---|---|---|
| T4 | <neochapay> @akaWolf [@neochapay https://github.com/nemomobile-ux/gl …], add some comments | 14:03 |
| T4 | <akaWolf> where? | 14:04 |
| T4 | <neochapay> https://github.com/nemomobile-ux/glacier-settings/pull/15/files#r240620548 | 14:04 |
| T4 | <akaWolf> commit message, mr description, source code? | 14:04 |
| T4 | <akaWolf> @neochapay btw why absolute paths better then relatives one? | 14:13 |
| T4 | <neochapay> @akaWolf [@neochapay btw why absolute paths better then …], We always do that :) | 14:13 |
| T4 | <akaWolf> but should be the reason... | 14:13 |
| T4 | <neochapay> ask @locusf | 14:14 |
| T4 | <faenil> Actually Images should go through the theme image provider | 14:14 |
| T4 | <faenil> I don't even remember if there's still one in nemo though :) | 14:14 |
| T4 | <eekkelund> @faenil [I don't even remember if there's still one in …], Yes there is | 14:15 |
| T4 | <akaWolf> sounds reasonable | 14:15 |
| T4 | <faenil> You shouldn't use abs or rel paths to refer to system images, they should be part of the theme and accessed through the theme img provider using its schema | 14:15 |
| T4 | <faenil> Such as images:// or theme:// or whichever it was | 14:15 |
| T4 | <akaWolf> yeah, it can be done as separate task, but for current solution I dont think abs is better then rel | 14:17 |
| T4 | <faenil> Why separate task? @eekkelund said we already have an img provider | 14:17 |
| T4 | <akaWolf> well that application doesnt use img provider et all | 14:18 |
| T4 | <faenil> Then that should be fixed :) | 14:19 |
| T4 | <eekkelund> example with glacier-settings, application where you submitted PR … https://github.com/nemomobile-ux/glacier-settings/blob/c6ddfc4cce298bd470dca20dc60d43c79a11c090/qml/plugins/wifi/wifi.qml#L112 | 14:19 |
| T4 | <akaWolf> @eekkelund [example with glacier-settings, application whe …], okay sorry | 14:19 |
| T4 | <akaWolf> I see | 14:19 |
| T4 | <eekkelund> @faenil [Then that should be fixed :)], And yeah, the paths should be fixed. and if there is images that are not part of nemo-theme,-glacier then you should make a PR to nemo-theme-glacier :) … https://github.com/nemomobile-ux/nemo-theme-glacier | 14:20 |
| T4 | <eekkelund> not you @faenil, but in general ^ :D | 14:20 |
| T4 | <akaWolf> I didnt modify the original code, so there was … https://github.com/nemomobile-ux/glacier-settings/blob/c6ddfc4cce298bd470dca20dc60d43c79a11c090/qml/plugins/wifi/wifi.qml#L131 | 14:21 |
| T4 | <eekkelund> @akaWolf [I didnt modify the original code, so there was …], And it should be changed, as well as hardcoded sizes :) | 14:22 |
| T4 | <faenil> @eekkelund [not you @faenil, but in general ^ :D], Good boy :D | 14:24 |
| T4 | <akaWolf> @eekkelund [And it should be changed, as well as hardcoded …], there are no such images in `nemo-theme-glacier`. I would fix that in separate MR | 14:29 |
| T4 | <eekkelund> then images should be moved from glacier-settings to nemo-theme-glacier, like you said :) | 14:31 |
| T4 | <akaWolf> yeah, okay | 14:31 |
| T4 | <akaWolf> @neochapay do you think it's still actual to chane rel to abs? | 14:32 |
| T4 | <akaWolf> [Edit] @neochapay do you think it's still actual to change rel to abs? | 14:32 |
| *** ChanServ sets mode: +v T4 | 14:46 | |
| T4 | <neochapay> @akaWolf [@neochapay do you think it's still actual to c …], yeap | 14:51 |
| T4 | <akaWolf> okay =) | 14:57 |
| T4 | <faenil> Guys, what is the hurry to merge that? | 15:31 |
| T4 | <locusf> omp deadlines ;) ? | 15:31 |
| T4 | <faenil> If theme provider is missing icons or functionality, we need to fix that first | 15:31 |
| T4 | <faenil> Deadlines are fine, there are separate branches for that ;) | 15:32 |
| T4 | <faenil> Just not merge to master | 15:32 |
| *** ChanServ sets mode: +v T4 | 20:28 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!