*** M4rtinK2 has quit IRC | 00:05 | |
*** M4rtinK has joined #nemomobile | 00:08 | |
*** M4rtinK has quit IRC | 00:14 | |
*** dionet has quit IRC | 00:51 | |
*** KaIRC has quit IRC | 00:53 | |
*** arcean_ has quit IRC | 01:03 | |
*** KaIRC has joined #nemomobile | 01:06 | |
*** himamura has quit IRC | 01:38 | |
*** jluisn has joined #nemomobile | 02:00 | |
*** jluisn has quit IRC | 02:00 | |
*** himamura has joined #nemomobile | 02:01 | |
*** himamura has joined #nemomobile | 02:02 | |
*** himamura has quit IRC | 02:06 | |
*** himamura has joined #nemomobile | 02:09 | |
*** rcg has quit IRC | 02:11 | |
*** himamura has quit IRC | 02:17 | |
*** KaIRC has quit IRC | 02:18 | |
*** himamura has joined #nemomobile | 02:20 | |
*** himamura has quit IRC | 02:23 | |
*** himamura has joined #nemomobile | 02:25 | |
*** rcg has joined #nemomobile | 02:28 | |
*** himamura has quit IRC | 02:29 | |
*** himamura has joined #nemomobile | 02:32 | |
*** himamura has quit IRC | 02:35 | |
*** himamura has joined #nemomobile | 02:35 | |
*** himamura has quit IRC | 02:39 | |
*** himamura has joined #nemomobile | 02:43 | |
*** himamura has quit IRC | 02:47 | |
*** himamura has joined #nemomobile | 02:50 | |
*** himamura_ has joined #nemomobile | 02:53 | |
*** himamura has quit IRC | 02:54 | |
*** himamura has joined #nemomobile | 02:57 | |
*** himamura_ has quit IRC | 02:57 | |
*** himamura has quit IRC | 03:01 | |
*** himamura has joined #nemomobile | 03:13 | |
*** himamura has quit IRC | 03:17 | |
*** himamura has joined #nemomobile | 03:20 | |
*** himamura has quit IRC | 03:24 | |
*** Estel_ has quit IRC | 03:30 | |
*** himamura has joined #nemomobile | 03:40 | |
*** Estel_ has joined #nemomobile | 03:41 | |
*** furikku has joined #nemomobile | 03:48 | |
*** the-boss has quit IRC | 03:59 | |
*** the-boss has joined #nemomobile | 04:04 | |
*** himamura has quit IRC | 04:12 | |
iekku | morning | 04:45 |
---|---|---|
*** lofty306 has left #nemomobile | 05:14 | |
rcg | morning | 05:21 |
Stskeeps | rcg: did you have a fix for the calendar crash for kcalcore/qt mobility or how was it? | 05:21 |
rcg | yes | 05:22 |
rcg | Stskeeps: i attached a updated patch to the bug report | 05:22 |
Stskeeps | for various legal reasons we can't accept patches within bugzilla.. we need it submitted through git with a signed-off-by | 05:22 |
Stskeeps | i should probably note that other places | 05:22 |
rcg | actually, i intended to ping you so i can learn how to do this "officially" | 05:23 |
Stskeeps | :nod: | 05:23 |
rcg | however, i didn't have the time yet :( | 05:23 |
rcg | alright, first question: is it sufficient that i simply add this "signed off by /me"? | 05:24 |
Stskeeps | yes | 05:24 |
Stskeeps | let me show you | 05:24 |
rcg | cool | 05:24 |
Stskeeps | .. or try.. | 05:24 |
* Stskeeps pokes meego.com with a stick | 05:24 | |
Stskeeps | http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html | 05:25 |
rcg | alright, sounds simple and fair | 05:27 |
Stskeeps | it's basically so we have some protection in case anybody has submitted bad stuff, and we can find it and remove it | 05:28 |
rcg | i see | 05:28 |
Stskeeps | and can point blame to a specific person/commits | 05:28 |
Stskeeps | same system linux kernel works with | 05:30 |
rcg | right :) | 05:36 |
rcg | just registering @ gerrit | 05:40 |
*** Siosm has joined #nemomobile | 05:46 | |
*** Siosm has quit IRC | 05:50 | |
rcg | Stskeeps: does it take some time until an ssh key is accepted in gerrit? | 05:55 |
Stskeeps | no, shouldn't | 05:55 |
Stskeeps | tell me how you test it? | 05:56 |
rcg | ssh -p 29418 ruedigergad@review.merproject.org gerrit ls-projects | 05:56 |
Stskeeps | sounds about right, did you set username in settings->profile ? | 05:56 |
rcg | ah right | 05:57 |
rcg | username was not set | 05:57 |
rcg | thought i had set it as i registered | 05:57 |
rcg | yes, works now, set it via the settings in the web gui.. apparently it was empty before | 05:57 |
Stskeeps | good | 05:58 |
*** himamura has joined #nemomobile | 05:59 | |
rcg | alright: http://review.merproject.org/#change,636 | 06:05 |
*** Aard has quit IRC | 06:06 | |
rcg | Stskeeps: ^ | 06:06 |
Stskeeps | a good start, you also need to modify the spec/yaml file ;) | 06:07 |
Stskeeps | doesn't get picked up automatically | 06:07 |
*** himamura has quit IRC | 06:07 | |
Stskeeps | get mer platform sdk, add patch to .yaml file, run 'specify | 06:07 |
rcg | i just replaced an existing patch | 06:09 |
rcg | that is, i kinda patched a patch | 06:09 |
Stskeeps | ah | 06:09 |
Stskeeps | well, then you need to add an entry to .changes too | 06:09 |
rcg | but i guess i would need to update the version in the yaml? | 06:10 |
Stskeeps | nah, no need | 06:10 |
rcg | ah, missed that :) | 06:10 |
rcg | will update changes as well | 06:10 |
rcg | Stskeeps: http://review.merproject.org/#change,637 | 06:13 |
rcg | so, this is it? | 06:13 |
Stskeeps | sortof, https://wiki.merproject.org/wiki/Contribution_in_detail#Re-submit_if_original_change_was_rejected | 06:14 |
Stskeeps | git checkout the older sha, 0436001340b5b30d5cb74dd87a1b502a693b6411 and amend the commit | 06:15 |
Stskeeps | the goal is a proper clean commit, so you amend and re-submit | 06:15 |
rcg | ah, so i should have used --amend instead of simply commiting.. | 06:16 |
rcg | hmm.. unfortunately my git skills are rather basic :( | 06:17 |
Stskeeps | don't worry :) | 06:19 |
Stskeeps | it takes a bit to get used to but once it's down in muscle memory, its' quite easy | 06:19 |
rcg | hmm.. did that | 06:22 |
rcg | but i think it didnt pick up my change in the changes file? | 06:23 |
Stskeeps | did you git add the .changes file, then commit --amend ? | 06:24 |
Stskeeps | well | 06:24 |
Stskeeps | ok, when you checked out your older sha, the .changes change naturally disappeared | 06:24 |
Stskeeps | as you went earlier back in the source tree | 06:24 |
rcg | did: git checkout 0436001340b5b30d5cb74dd87a1b502a693b64 && vim mkcal.changes && git commit -s --amend && git push origin HEAD:refs/for/master | 06:25 |
Stskeeps | ah, you forgot git add mkcal.changes | 06:25 |
Stskeeps | you can just git add mkcal.changes and amend again | 06:26 |
rcg | ah was missing -a | 06:26 |
rcg | on commit | 06:26 |
Stskeeps | and remember to read about Change-id | 06:26 |
Stskeeps | before pushing next | 06:26 |
rcg | ah, yeah, sorry | 06:28 |
rcg | man.. i am really in a hurry... | 06:29 |
rcg | this does not compute well for me right now :( | 06:29 |
rcg | always making mistakes :( | 06:29 |
rcg | and keep spamming you guys with new change id's | 06:29 |
Stskeeps | it's fine, just click 'abandon change' in the end | 06:30 |
Stskeeps | just continue some other time :) | 06:30 |
rcg | alright, i am just on my last try | 06:31 |
rcg | with Change-Id: in the last line i simply put "636" or do i put "Change-Id:636"? | 06:32 |
Stskeeps | Change-Id: Ib5a4abac1d8e882d15b67b59474faf1a12ce2290 | 06:32 |
Stskeeps | see top of the changes page | 06:32 |
rcg | i see, and should i prefix it with "Change-Id:"? | 06:33 |
Stskeeps | just as is, 'Change-Id: Ib5a4abac1d8e882d15b67b59474faf1a12ce2290' | 06:34 |
rcg | yay, looks like this time i got it right :) | 06:35 |
rcg | http://review.merproject.org/#change,636 | 06:35 |
Stskeeps | yup, i see a patch set 2 | 06:35 |
rcg | thanks a lot Stskeeps for the help and patience.. :) and now i gotta head off to shower and sprint to work ;) | 06:36 |
Stskeeps | enjoy | 06:36 |
rcg | Stskeeps: alright, just quickly abandoned the changes i spammed accidently | 06:44 |
rcg | hope this was the right way to do it | 06:44 |
Stskeeps | :nod: | 06:45 |
*** jukkaeklund has joined #nemomobile | 07:50 | |
*** rcg-work has joined #nemomobile | 08:02 | |
*** ronoc has joined #nemomobile | 08:06 | |
*** slaine has joined #nemomobile | 08:33 | |
*** cxl000 has joined #nemomobile | 08:50 | |
*** M4rtinK has joined #nemomobile | 09:04 | |
*** phaeron has quit IRC | 09:11 | |
*** M4rtinK has quit IRC | 09:14 | |
*** arcean has joined #nemomobile | 09:17 | |
rantom | Has there been some planning on what to do with the desktop in Nemo Mobile? | 09:17 |
rantom | As far as I know it shows the background wallpaper, nothing else | 09:17 |
rantom | In english: is there a need to preserve the desktop as it is now or should it just be an application-grid/etc? | 09:18 |
rantom | Although I could understand if it would be used to display e.g. widgets | 09:23 |
*** M4rtinK has joined #nemomobile | 09:30 | |
*** himamura_ has joined #nemomobile | 09:33 | |
*** phaeron has joined #nemomobile | 10:36 | |
*** KaIRC has joined #nemomobile | 10:37 | |
*** phaeron1 has joined #nemomobile | 10:40 | |
*** phaeron has quit IRC | 10:42 | |
*** MohammadAG has quit IRC | 10:52 | |
*** MohammadAG has joined #nemomobile | 10:52 | |
*** niqt has joined #nemomobile | 10:52 | |
*** smyows has joined #nemomobile | 11:18 | |
*** smyows has joined #nemomobile | 11:18 | |
*** arcean has quit IRC | 11:23 | |
*** arcean has joined #nemomobile | 11:25 | |
*** lizardo has joined #nemomobile | 11:37 | |
Sage_ | Problem: nothing provides /usr/bin/ruby needed by meegotouch-applauncherd-tests-3.0.3-3.3.Project.MTF.MW.armv7hl | 11:54 |
Sage_ | ... | 11:54 |
Stskeeps | yes, that's my reaction to some of this stuff too | 11:55 |
Stskeeps | you're thinking TDriver | 11:55 |
Sage_ | yes | 11:55 |
* Sage_ though ruby was already in Mer:Tools:Testing with tdriver | 11:56 | |
Sage_ | ah, no. It is only in my prj. https://build.pub.meego.com/project/packages?project=home%3Asage%3Abranches%3AMer%3ATools%3ATesting | 11:57 |
* Sage_ though he pushed those already :/ | 11:59 | |
*** himamura_ has quit IRC | 12:05 | |
*** jd is now known as Jade | 12:12 | |
*** lofty306 has joined #nemomobile | 12:17 | |
*** ronoc has quit IRC | 12:21 | |
*** jluisn has joined #nemomobile | 12:29 | |
*** rcg-work1 has joined #nemomobile | 12:45 | |
*** rcg-work has quit IRC | 12:46 | |
*** lofty306 has left #nemomobile | 12:58 | |
*** ronoc has joined #nemomobile | 13:03 | |
*** ronoc has quit IRC | 13:09 | |
*** jluisn_ has joined #nemomobile | 13:16 | |
*** jluisn has quit IRC | 13:17 | |
*** DocScrutinizer has quit IRC | 13:26 | |
*** DocScrutinizer has joined #nemomobile | 13:26 | |
*** ronoc has joined #nemomobile | 13:37 | |
*** niqt has quit IRC | 13:38 | |
*** ronoc has quit IRC | 13:44 | |
*** ronoc has joined #nemomobile | 13:45 | |
*** niqt has joined #nemomobile | 14:28 | |
*** niqt has quit IRC | 14:41 | |
*** jluisn has joined #nemomobile | 15:21 | |
*** faenil has joined #nemomobile | 15:21 | |
*** jluisn_ has quit IRC | 15:23 | |
*** phaeron1 has quit IRC | 15:44 | |
*** slaine has quit IRC | 15:44 | |
*** himamura has joined #nemomobile | 15:47 | |
*** NIN101 has joined #nemomobile | 15:55 | |
*** himamura has quit IRC | 16:02 | |
*** himamura has joined #nemomobile | 16:05 | |
*** himamura_ has joined #nemomobile | 16:30 | |
*** radiofree has quit IRC | 16:32 | |
*** radiofree_ has joined #nemomobile | 16:32 | |
*** himamura has quit IRC | 16:33 | |
*** himamura_ has quit IRC | 16:55 | |
*** himamura has joined #nemomobile | 16:56 | |
*** himamura has quit IRC | 16:56 | |
*** himamura has joined #nemomobile | 16:59 | |
*** radiofree_ is now known as radiofree | 17:02 | |
*** himamura_ has joined #nemomobile | 17:04 | |
*** himamura has quit IRC | 17:07 | |
*** dionet has joined #nemomobile | 17:08 | |
*** NIN101 has quit IRC | 17:15 | |
*** the-boss has quit IRC | 17:18 | |
*** rcg-work1 has quit IRC | 17:19 | |
*** the-boss has joined #nemomobile | 17:27 | |
*** nsuffys has joined #nemomobile | 17:41 | |
*** himamura has joined #nemomobile | 17:55 | |
*** faenil has quit IRC | 17:57 | |
*** phaeron has joined #nemomobile | 17:58 | |
*** himamura_ has quit IRC | 17:58 | |
*** himamura_ has joined #nemomobile | 18:02 | |
*** himamura_ has joined #nemomobile | 18:02 | |
*** himamura has quit IRC | 18:05 | |
*** furikku has quit IRC | 18:08 | |
*** arcean has quit IRC | 18:28 | |
*** NIN101 has joined #nemomobile | 18:44 | |
*** nsuffys has quit IRC | 19:25 | |
*** ronoc has quit IRC | 19:34 | |
*** ronoc has joined #nemomobile | 19:49 | |
rcg | Sage_: ping | 20:08 |
Sage_ | rcg: pong | 20:12 |
rcg | how do you prefer the patch? | 20:13 |
rcg | http://review.merproject.org/#change,636 | 20:13 |
rcg | i plan to just add myself as "signed-off-by" for the particular change | 20:14 |
Sage_ | rcg: Well, one way is to do: git init; git add *; git commit -m.; CHANGES ; git commit -a; git format-patch -1 | 20:14 |
rcg | am currently figuring out how to do the git diff stuff | 20:14 |
rcg | alright | 20:15 |
Sage_ | but you can also checkout the upstream tree if you want, but that for the tarball works as well | 20:15 |
rcg | i plan to preserve your "signed-off-by" message and just add me to it | 20:15 |
rcg | alright, thanks | 20:15 |
rcg | i think i slowly get into the deeper bits of git | 20:15 |
Sage_ | :) | 20:16 |
Sage_ | that is the way it usually goes | 20:16 |
rcg | i see :) | 20:16 |
rcg | this morning i felt quite stupid when Stskeeps guided me through the process in gerrit.. but i hope i remember everything and don't spam gerrit again ;) | 20:18 |
rcg | Sage_: http://review.merproject.org/#change,636 | 20:36 |
rcg | i _think_ that should have worked | 20:36 |
*** ronoc has quit IRC | 20:44 | |
Sage_ | rcg: is the notifyOpened used somewhere btw? | 20:53 |
rcg | it is | 20:53 |
rcg | iirc in some places | 20:53 |
Sage_ | ok | 20:54 |
rcg | so i figured letting it return false instead of removing the calls would be easier | 20:54 |
rcg | also returning false corresponds to its logic | 20:54 |
Sage_ | well that patch seems ok to me. | 20:55 |
rcg | great :) | 20:55 |
Sage_ | .changes needs fix though :) | 20:56 |
Sage_ | - Fixes MER#387: summary... | 20:56 |
Sage_ | not - Fix #MER387: summary... | 20:56 |
rcg | alright, the very details ;) | 20:57 |
rcg | but am getting closer :) | 20:57 |
Sage_ | well, I hope we get at somepoint parser that automatically reports also to bugzilla about changes thus it will be nice to keep syntax same. | 20:58 |
rcg | sure, didn't want to nag ;) | 20:59 |
rcg | just commited the fixed changes file | 20:59 |
Sage_ | rcg: I don't want to nag, but it is MER#387 not #MER387 ;) | 21:02 |
*** dionet has quit IRC | 21:03 | |
rcg | ah, damn... missed that, gimme just a sec :) | 21:03 |
Sage_ | Well, take 10 ;) | 21:05 |
rcg | alright | 21:05 |
rcg | hope that's it | 21:05 |
rcg | ;) | 21:05 |
Sage_ | well, gave +1 instead of -2 ;) | 21:06 |
*** NIN101 has quit IRC | 21:06 | |
rcg | right :) | 21:06 |
rcg | well, that last details were tougher work than i expected ;) | 21:07 |
*** jluisn has quit IRC | 21:10 | |
lbt | rcg: it's OK, I just -1'ed one of Sage_'s submits :) | 21:12 |
*** smyows has quit IRC | 21:14 | |
rcg | lbt: i see :) | 21:16 |
rcg | it always is kinda relieving to see you are not alone ;) | 21:17 |
lbt | hehe... you should see my attempts... | 21:17 |
lbt | the problem is that when you don't do it everyday, you miss things | 21:17 |
rcg | anyway, learned quite a lot.. and i really need to update my git cheat sheet before i loose my .bash_history :) | 21:17 |
lbt | that's why I wrote the tutorial.... to remind myself | 21:18 |
rcg | hehe, yeah, right :) | 21:18 |
lbt | feels good to get your first change in though ... congrats :) | 21:19 |
lbt | any comments on the wiki page? | 21:19 |
rcg | ah, well, it's not completely through yet, need another +1 ;) | 21:22 |
Sage_ | lbt: about the 191 I'm not sure if that is relevant | 21:22 |
rcg | but thanks, yeah, it is quite interesting to work on the official mer :) | 21:22 |
rcg | personally i found the wiki page very informative but there could be a section that describes how to deal with rejected changes in more detail | 21:23 |
Sage_ | lbt: ah, and 412 is actually fixed already. Just didn't know that there was bug about it :) | 21:23 |
rcg | personally, i missed an example of the command lines used for git | 21:23 |
Sage_ | lbt: will add comment about 412 | 21:23 |
rcg | and also an actual example on how to place the "Change-Id:" entry in the change log | 21:24 |
rcg | dunno why but i had some blocks in my mind on doing this and a real life example would have helped imho | 21:25 |
Sage_ | lbt: I would have given -2 but you are too nice ;) | 21:25 |
lbt | Sage_: the 191 is more that you're touching the package and 191 should be a trivial thing to avoid 2 change/review cycles | 21:26 |
lbt | since vendors should do QA on it | 21:26 |
lbt | in fact... | 21:26 |
lbt | we should actually do an 'outstanding bugs for this package' check | 21:26 |
Sage_ | I always try to do search with package name before pushing any changes to check if I can fix other things as well. | 21:27 |
lbt | rcg: OK - if you want to make some edits there and ask someone (me, sage, Stskeeps) to validate then that'd be good | 21:27 |
Sage_ | lbt: I didn't get the 191 comment. | 21:28 |
lbt | Sage_: yeah - that should be in the checklist on the wiki actially | 21:28 |
lbt | https://bugs.merproject.org/show_bug.cgi?id=191 ? | 21:29 |
Sage_ | yes. the opensslconf.h file is different on intel and arm. On ARM it uses the one provided on upstream and on Intel it uses the one originated from fedora | 21:30 |
Sage_ | I don't know if ARM has any multilib arches that would need that patch | 21:31 |
rcg | lbt: yes, i hope i'll find the time to make some personal notes first and then might edit the wiki | 21:31 |
Sage_ | e.g. on intel you might want to install 64bit and 32bit packages thus the fix is there if I understood correctly. | 21:32 |
rcg | unfortunately there are only so many hours in a day.. same problem as usual, so much to do, so few time | 21:32 |
Sage_ | Time to sleep.. good night everyone. | 21:33 |
lbt | Sage_: hmm | 21:33 |
lbt | OK | 21:34 |
lbt | anyhow, g'night | 21:34 |
rcg | btw, how do you guys manage to invest that much time into mer/nemo? | 21:40 |
*** lizardo has quit IRC | 21:58 | |
*** cxl000 has quit IRC | 22:32 | |
*** DocScrutinizer05 has joined #nemomobile | 23:15 | |
*** M4rtinK has quit IRC | 23:30 | |
*** bef0rd has joined #nemomobile | 23:39 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!