| Thaodan | ln | 15:26 |
|---|---|---|
| Thaodan | lbt: can you look at my pr?https://github.com/mer-hybris/mer-kernel-check/pull/15 | 15:26 |
| mal | Thaodan: is that whitespace change on line 200 of modified file intentional? | 15:28 |
| mal | also line 71 has some mismatching indentation | 15:28 |
| mal | and missing whitespace around => | 15:29 |
| mal | line 117 has also formatting issues | 15:29 |
| Thaodan | I look into that. The whitepace in line 200 is in the unmodified too and wasn't added by me | 15:32 |
| mal | also some other inconsistencies in formatting (mostly in ifs) | 15:33 |
| mal | Thaodan: it used to be a tab but you changed it to spaces | 15:33 |
| mal | i.e. the tab before the y | 15:33 |
| Thaodan_ | mal: fixed that, also added docs to cmp_version | 16:56 |
| mal | Thaodan_: it seems you misunderstood me and broke tabs even more in the list near the end of the file | 17:47 |
| mal | also lines 123 and 128 still have some formatting issues in the ifs | 17:47 |
| mal | and line 130 is missing spaces around = | 17:48 |
| *** Thaodan_ is now known as Thai | 23:11 | |
| *** Thai is now known as thaodan | 23:11 | |
| *** thaodan is now known as Thaodan | 23:12 | |
| Thaodan | mal: please look again I fixed line 130, changed the ifs to be like the others and redid the changes to __DATA__ to preserve the tabs | 23:42 |
| mal | I will comment things tomorrow, still some issues | 23:53 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!